Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[platform/broadcom] Add Celestica Silverstone-DP platform module #117

Conversation

pphuchar
Copy link
Collaborator

@pphuchar pphuchar commented Sep 30, 2019

- What I did
Add Silverstone-DP platform module package
- How I did it
Add the kernel module driver and basic device plugins and HwSKU
- How to verify it
Build the image and check if the platform module starts after SONiC bootup.

@pphuchar pphuchar requested a review from mudsut4ke September 30, 2019 08:21
@pphuchar pphuchar force-pushed the add-platform-silverstone-dp branch from 0771a1e to 6734720 Compare October 1, 2019 11:56
@pphuchar pphuchar requested a review from tiantianlv October 8, 2019 11:19
@pphuchar pphuchar force-pushed the add-platform-silverstone-dp branch from 6734720 to 18c9222 Compare October 8, 2019 12:34
@pphuchar
Copy link
Collaborator Author

pphuchar commented Oct 8, 2019

Silverstone-DP EVT BSP test result

This test verify basic Silverstone-DP platform module and device plugins.

Known Issue:

  1. The management port have an issue that cannot operate at 1 Gb/s
  2. SAI is not ready yet.

Test setup:

  1. Set MGMT port speed to 100 Mb/s
    sudo ethtool -s eth0 speed 100 duplex full
  2. No QSFP or QSFP-DD plugin.

Test result

admin@sonic:~$ show version

SONiC Software Version: SONiC.add-platform-silverstone-dp.0-dirty-20191001.210736
Distribution: Debian 9.11
Kernel: 4.9.0-9-2-amd64
Build commit: 67347203
Build date: Tue Oct  1 15:16:35 UTC 2019
Built by: tdcadmin@CTHD0573

Platform: x86_64-cel_silverstone_dp-r0
HwSKU: Silverstone-DP
ASIC: broadcom
Serial Number: YW5ldnR1bml0
Uptime: 18:11:05 up 4 min,  1 user,  load average: 1.75, 1.19, 0.52

Docker images:
REPOSITORY                 TAG                                                   IMAGE ID            SIZE
docker-syncd-brcm          add-platform-silverstone-dp.0-dirty-20191001.210736   975c00de2013        392MB
docker-syncd-brcm          latest                                                975c00de2013        392MB
docker-fpm-frr             add-platform-silverstone-dp.0-dirty-20191001.210736   9cd39fed3bd3        318MB
docker-fpm-frr             latest                                                9cd39fed3bd3        318MB
docker-sflow               add-platform-silverstone-dp.0-dirty-20191001.210736   39c3d2871254        302MB
docker-sflow               latest                                                39c3d2871254        302MB
docker-lldp-sv2            add-platform-silverstone-dp.0-dirty-20191001.210736   01a5ec79cc36        298MB
docker-lldp-sv2            latest                                                01a5ec79cc36        298MB
docker-dhcp-relay          add-platform-silverstone-dp.0-dirty-20191001.210736   25386fc99918        289MB
docker-dhcp-relay          latest                                                25386fc99918        289MB
docker-database            add-platform-silverstone-dp.0-dirty-20191001.210736   08396ace379d        280MB
docker-database            latest                                                08396ace379d        280MB
docker-snmp-sv2            add-platform-silverstone-dp.0-dirty-20191001.210736   c3efaad4133d        334MB
docker-snmp-sv2            latest                                                c3efaad4133d        334MB
docker-orchagent           add-platform-silverstone-dp.0-dirty-20191001.210736   3677e3a22235        320MB
docker-orchagent           latest                                                3677e3a22235        320MB
docker-teamd               add-platform-silverstone-dp.0-dirty-20191001.210736   b19d3ea4cfb8        302MB
docker-teamd               latest                                                b19d3ea4cfb8        302MB
docker-sonic-telemetry     add-platform-silverstone-dp.0-dirty-20191001.210736   e7188ff22fa0        303MB
docker-sonic-telemetry     latest                                                e7188ff22fa0        303MB
docker-router-advertiser   add-platform-silverstone-dp.0-dirty-20191001.210736   a9573756cf54        281MB
docker-router-advertiser   latest                                                a9573756cf54        281MB
docker-platform-monitor    add-platform-silverstone-dp.0-dirty-20191001.210736   fc0d1ad1369d        325MB
docker-platform-monitor    latest                                                fc0d1ad1369d        325MB

PSU and EEPROM

admin@sonic:~$ sudo psuutil status
PSU    Status
-----  --------
PSU 1  OK
PSU 2  OK
admin@sonic:~$ sudo decode-syseeprom 
TlvInfo Header:
   Id String:    TlvInfo
   Version:      1
   Total Length: 78
TLV Name             Code Len Value
-------------------- ---- --- -----
Product Name         0x21  14 Silverstone DP
MAC Addresses        0x2A   2 1
Platform Name        0x28  28 x86_64-cel_silverstone-dp-r0
Base MAC Address     0x24   6 00:E0:EC:12:57:01
Serial Number        0x23  12 YW5ldnR1bml0
CRC-32               0xFE   4 0xC6ED8141
(checksum valid)

sfputil

Port presence and EEPROM decoding need to be retest when have QSFP and QSFP-DD ports.

admin@sonic:~$ sudo sfputil show presence
Port         Presence
-----------  -----------
Ethernet0    Not present
Ethernet4    Not present
Ethernet8    Not present
Ethernet12   Not present
Ethernet16   Not present
Ethernet20   Not present
Ethernet24   Not present
Ethernet28   Not present
Ethernet32   Not present
Ethernet36   Not present
Ethernet40   Not present
Ethernet44   Not present
Ethernet48   Not present
Ethernet52   Not present
Ethernet56   Not present
Ethernet60   Not present
Ethernet64   Not present
Ethernet68   Not present
Ethernet72   Not present
Ethernet76   Not present
Ethernet80   Not present
Ethernet84   Not present
Ethernet88   Not present
Ethernet92   Not present
Ethernet96   Not present
Ethernet100  Not present
Ethernet104  Not present
Ethernet108  Not present
Ethernet112  Not present
Ethernet116  Not present
admin@sonic:~$ sudo sfputil show eeprom
Ethernet0: SFP EEPROM not detected

Ethernet4: SFP EEPROM not detected

Ethernet8: SFP EEPROM not detected

Ethernet12: SFP EEPROM not detected

Ethernet16: SFP EEPROM not detected

Ethernet20: SFP EEPROM not detected

Ethernet24: SFP EEPROM not detected

Ethernet28: SFP EEPROM not detected

Ethernet32: SFP EEPROM not detected

Ethernet36: SFP EEPROM not detected

Ethernet40: SFP EEPROM not detected

Ethernet44: SFP EEPROM not detected

Ethernet48: SFP EEPROM not detected

Ethernet52: SFP EEPROM not detected

Ethernet56: SFP EEPROM not detected

Ethernet60: SFP EEPROM not detected

Ethernet64: SFP EEPROM not detected

Ethernet68: SFP EEPROM not detected

Ethernet72: SFP EEPROM not detected

Ethernet76: SFP EEPROM not detected

Ethernet80: SFP EEPROM not detected

Ethernet84: SFP EEPROM not detected

Ethernet88: SFP EEPROM not detected

Ethernet92: SFP EEPROM not detected

Ethernet96: SFP EEPROM not detected

Ethernet100: SFP EEPROM not detected

Ethernet104: SFP EEPROM not detected

Ethernet108: SFP EEPROM not detected

Ethernet112: SFP EEPROM not detected

Ethernet116: SFP EEPROM not detected


admin@sonic:~$ sudo sfputil show lpmode
Port         Low-power Mode
-----------  ----------------
Ethernet0    Off
Ethernet4    Off
Ethernet8    Off
Ethernet12   Off
Ethernet16   Off
Ethernet20   Off
Ethernet24   Off
Ethernet28   Off
Ethernet32   Off
Ethernet36   Off
Ethernet40   Off
Ethernet44   Off
Ethernet48   Off
Ethernet52   Off
Ethernet56   Off
Ethernet60   Off
Ethernet64   Off
Ethernet68   Off
Ethernet72   Off
Ethernet76   Off
Ethernet80   Off
Ethernet84   Off
Ethernet88   Off
Ethernet92   Off
Ethernet96   Off
Ethernet100  Off
Ethernet104  Off
Ethernet108  Off
Ethernet112  Off
Ethernet116  Off
admin@sonic:~$ for i in {0..116..4}; do sudo sfputil reset Ethernet$i; done
Resetting port Ethernet0...  OK
Resetting port Ethernet4...  OK
Resetting port Ethernet8...  OK
Resetting port Ethernet12...  OK
Resetting port Ethernet16...  OK
Resetting port Ethernet20...  OK
Resetting port Ethernet24...  OK
Resetting port Ethernet28...  OK
Resetting port Ethernet32...  OK
Resetting port Ethernet36...  OK
Resetting port Ethernet40...  OK
Resetting port Ethernet44...  OK
Resetting port Ethernet48...  OK
Resetting port Ethernet52...  OK
Resetting port Ethernet56...  OK
Resetting port Ethernet60...  OK
Resetting port Ethernet64...  OK
Resetting port Ethernet68...  OK
Resetting port Ethernet72...  OK
Resetting port Ethernet76...  OK
Resetting port Ethernet80...  OK
Resetting port Ethernet84...  OK
Resetting port Ethernet88...  OK
Resetting port Ethernet92...  OK
Resetting port Ethernet96...  OK
Resetting port Ethernet100...  OK
Resetting port Ethernet104...  OK
Resetting port Ethernet108...  OK
Resetting port Ethernet112...  OK
Resetting port Ethernet116...  OK
admin@sonic:~$ 

@pphuchar pphuchar changed the title [platform/broadcom] Add Celstica Silverstone-DP platform module [platform/broadcom] Add Celestica Silverstone-DP platform module Oct 9, 2019
@pphuchar pphuchar merged this pull request into SONIC-DEV:upstream_silverstone-dp Oct 16, 2019
mudsut4ke pushed a commit that referenced this pull request Jan 25, 2021
…nic-net#5924)

This should also fix the vsimage check build.

Commits include:

* src/sonic-platform-common a659219...e4883e5 (7):
  > [PsuBase] Reference inherited member constant (#142)
  > Thermalctld APIs for recording min and max temp (#131)
  > Common power consumption and supply APIs for modular chassis (#136)
  > [sonic-platform-base] Introduce APIs for modular chassis support (#124)
  > Remove shebangs from non-executable Python files (#140)
  > [sonic_eeprom] Make compatible with Python 2 and 3 (#127)
  > Add unit test infrastructure (#139)

* src/sonic-platform-daemons 600d043...be21d91 (9):
  > [psud] Import of mock libraries determined by environment variable (#117)
  > [chassisd][thermalctld] Set testing env var at top of file, not in setup_function() (#114)
  > [chassisd][thermalctld] Import os module, now needed for env var checking (#113)
  > [chassisd][thermalctld] Import mock libraries based on environment variable (#112)
  > [xcvrd] Fix the console-script xcvrd startup  (#111)
  > [Thermalctld] Update thermal info to CHASSIS_STATE_DB (#101)
  > PSUd changes to compute power-budget for Modular chassis (#104)
  > Introduce chassisd to monitor status of cards on chassis (#97)
  > [xcvrd] support for integrating Credo Y cable Ports initialization and status updates with xcvrd.  (#105)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants