Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #284 - Padronizar Termos: Alterar "necessita urgentemente" para "precisa com urgência" #288

Merged
merged 5 commits into from
May 22, 2024

Conversation

rayanerocha07
Copy link
Contributor

@rayanerocha07 rayanerocha07 commented May 21, 2024

Relacionado à issue:
#284

Ao rodar o lint, reparei que o projeto tinha 5 warnings, relacionados a Separate Constants or Functions from Components.

antes:
image

depois:
image

Indicates that Fast Refresh works best when a file only exports components. If you have constants or functions that are not part of the component, move them to a separate file.

Consegui resolver 4 deles (não tenho taaaanta experiência com forms, rs), então achei válido manter nesse PR, mas caso fuja do padrão esperado por vocês, posso remover e deixar esse PR focado no objetivo da issue relacionada.

PS: ainda preciso instalar o backend para verificar se preciso modificar algo relacionado a esta issue (edit: não encontrei nada no backend).

@rayanerocha07 rayanerocha07 changed the title Resolves #284 Resolves #284 - Padronizar Termos: Alterar "necessita urgentemente" para "precisa com urgência" May 21, 2024
Copy link
Contributor

@Dan-Mqs Dan-Mqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vinny-silveira vinny-silveira self-requested a review May 22, 2024 12:45
Copy link
Contributor

@vinny-silveira vinny-silveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acredito que aqui também deveria ser mudado:

image

E aqui também:

image

O que achas @rhuam?

src/lib/utils.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@vinny-silveira vinny-silveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nível de codificação e funcionalidade tudo OK, PR apto ao merge.

@vinny-silveira vinny-silveira merged commit 2275040 into SOS-RS:develop May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Padronizar Termos: Alterar "necessita urgentemente" para "precisa com urgência"
5 participants