-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolves #284 - Padronizar Termos: Alterar "necessita urgentemente" para "precisa com urgência" #288
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A nível de codificação e funcionalidade tudo OK, PR apto ao merge.
Relacionado à issue:
#284
Ao rodar o lint, reparei que o projeto tinha 5 warnings, relacionados a
Separate Constants or Functions from Components
.antes:
depois:
Indicates that Fast Refresh works best when a file only exports components. If you have constants or functions that are not part of the component, move them to a separate file.
Consegui resolver 4 deles (não tenho taaaanta experiência com forms, rs), então achei válido manter nesse PR, mas caso fuja do padrão esperado por vocês, posso remover e deixar esse PR focado no objetivo da issue relacionada.
PS:
ainda preciso instalar o backend para verificar se preciso modificar algo relacionado a esta issue(edit: não encontrei nada no backend).