Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "TEST" to the first line #197

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

ameliefar
Copy link

(from my personal computer)

@LiamDBailey
Copy link
Collaborator

@ameliefar Looks to be working well!! Next, try requesting a review from Stefan or me (in the top right).

@ameliefar ameliefar marked this pull request as draft December 4, 2022 17:14
@ameliefar ameliefar marked this pull request as ready for review December 4, 2022 17:14
@ameliefar ameliefar marked this pull request as draft December 4, 2022 17:14
@ameliefar ameliefar marked this pull request as ready for review December 4, 2022 17:16
@ameliefar
Copy link
Author

Sorry for all of this, I'm trying to figure out why I can't click on "reviewers"

@ameliefar ameliefar marked this pull request as draft December 4, 2022 17:21
@ameliefar ameliefar marked this pull request as ready for review December 4, 2022 17:30
@LiamDBailey
Copy link
Collaborator

This is what it looks like to me (below). It might be because you don't have admin privileges here. In worst case scenario, we can assign the reviewers instead, although that's not ideal!

space

@LiamDBailey
Copy link
Collaborator

If that definitely doesn't work for you, we can try adding you with some limited privileges that allow you to manage pull requests. Let me know if you have some success!

@ameliefar
Copy link
Author

Here is a print screen showing what I have on the right side bar. I can't click on "reviewers" (my only option is "convert to draft"

ScreenPrint_reviewers

@StefanVriend
Copy link
Collaborator

This is what I find in relation to requesting a pull request review in the Github documentation (https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/requesting-a-pull-request-review):

image

@LiamDBailey
Copy link
Collaborator

Ok, so seems that at this stage @ameliefar wouldn't be able to assign (or be assigned) a reviewer. Is this a problem? Perhaps not, because Stefan or I can assign reviewers once we know the PR exists (if you send a message or tag us in a comment). We can, of course, give @ameliefar write access, but if we want to make this system more general (also to people that we might not know) we don't want a system where each person is expected to get write access.

What do you think @StefanVriend?

@StefanVriend
Copy link
Collaborator

In light of making things more general (and secure), I think your first suggestion is the best option. I guess it will be rather undemanding, as it shouldn't require more than a few clicks for us to assign a reviewer.

@ameliefar
Copy link
Author

@LiamDBailey @StefanVriend - I was just checking I could also do the process from my lab computer.

@StefanVriend StefanVriend self-requested a review December 6, 2022 09:46
Copy link
Collaborator

@StefanVriend StefanVriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just assigned myself as reviewer, did the review, and now it should be ready to merge.

Copy link
Collaborator

@StefanVriend StefanVriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realise now that I should have clicked 'approve' rather than 'comment'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants