-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add "TEST" to the first line #197
base: master
Are you sure you want to change the base?
Conversation
@ameliefar Looks to be working well!! Next, try requesting a review from Stefan or me (in the top right). |
Sorry for all of this, I'm trying to figure out why I can't click on "reviewers" |
If that definitely doesn't work for you, we can try adding you with some limited privileges that allow you to manage pull requests. Let me know if you have some success! |
This is what I find in relation to requesting a pull request review in the Github documentation (https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/requesting-a-pull-request-review): |
Ok, so seems that at this stage @ameliefar wouldn't be able to assign (or be assigned) a reviewer. Is this a problem? Perhaps not, because Stefan or I can assign reviewers once we know the PR exists (if you send a message or tag us in a comment). We can, of course, give @ameliefar write access, but if we want to make this system more general (also to people that we might not know) we don't want a system where each person is expected to get write access. What do you think @StefanVriend? |
In light of making things more general (and secure), I think your first suggestion is the best option. I guess it will be rather undemanding, as it shouldn't require more than a few clicks for us to assign a reviewer. |
@LiamDBailey @StefanVriend - I was just checking I could also do the process from my lab computer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just assigned myself as reviewer, did the review, and now it should be ready to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realise now that I should have clicked 'approve' rather than 'comment'.
(from my personal computer)