Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deeplink: fix web url with custom app scheme transformed to link #86

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

pyby
Copy link
Member

@pyby pyby commented Feb 8, 2024

Motivation and Context

First try in production #85 worked from https urls shared in mails, message or whatsapp.
But it does not work on a shared url in Facebook application, which open Play web in the internal Facebook web browser.

Play web uses in html header <meta data-react-helmet="true" property="al:ios:url"palysrf://www.srf.ch/play[…]>.
The JS parsePlayUrl parses correctly the urls but as the micro page url is transformed to a link?url=, it keeps the app custom scheme.
It creates a loop and the application stays on the home page.

Description

Checklist

  • The branch has been rebased onto the main branch.
  • The green check mark "All checks have passed" is displayed on the PR.
  • The documentation has been updated (if relevant).
  • Issues are linked to the PR, if any.

@pyby pyby added the bug Something isn't working label Feb 8, 2024
@rts-devops rts-devops temporarily deployed to playfff-deeplink-update-criuis February 8, 2024 20:57 Inactive
@pyby pyby changed the title Deeplink: support web url with custom app scheme Deeplink: fix web url with custom app scheme transformed to link Feb 8, 2024
@pyby
Copy link
Member Author

pyby commented Feb 8, 2024

Tested with Play SRF debug build on an iOS simulator and middlewareURL configuration url using the deployment of the PR:

xcrun simctl openurl booted "playsrf-debug://www.srf.ch/play/tv/micropages/_test-serien-mit-charakter?pageId=11faeeab-eb48-4192-93cf-22e99f1543b8"

Now opening the link in Safari mobile. 💁‍♂️

@pyby pyby added this pull request to the merge queue Feb 8, 2024
Merged via the queue into main with commit 3520d95 Feb 8, 2024
1 check passed
@pyby pyby deleted the deeplink-update branch February 8, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants