Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Exception #199

Closed
wants to merge 2 commits into from
Closed

Fix Exception #199

wants to merge 2 commits into from

Conversation

maxbachmann
Copy link
Contributor

Fix issue #156
the problem is that tryExecuteStep returns SQLITE_MISUSE when it was not used properly. Since this is set manually this is not the error state of the statement, so when checking the error message of the statement there obviously is none, since there was no error. This problem can not only occur in the exec function, but in executeStep aswell when used improperly. This PR fixes this problem for both functions by checking whether the error code is the same as the error state of the statement

@coveralls
Copy link

coveralls commented May 21, 2019

Coverage Status

Coverage increased (+0.03%) to 96.466% when pulling 36ea980 on maxbachmann:patch-1 into 8191379 on SRombauts:master.

@SRombauts SRombauts self-assigned this Jun 16, 2019
@SRombauts SRombauts added the bug label Jun 16, 2019
@SRombauts SRombauts closed this in 08a73ce Jun 16, 2019
@SRombauts
Copy link
Owner

Thanks again, looking good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants