Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow building of sqlite JSON1 extension when building internal sqlite library #288

Merged
merged 1 commit into from
Aug 3, 2020

Conversation

richardhozak
Copy link
Contributor

@richardhozak richardhozak commented Jul 29, 2020

I added cmake option to enable json1 extension when building internal sqlite library.
I added the option under the SQLITECPP_INTERNAL_SQLITE if statement so it is clear that this option is only valid when building the internal sqlite library.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 0d2294e on zxey:feature-json1-extension into 9106e8d on SRombauts:master.

@SRombauts SRombauts self-assigned this Aug 3, 2020
@SRombauts
Copy link
Owner

Hi @Zxey I wasn't aware of this extension, do you know since when it exists?

Anyway, I think it's a great feature 👍

The only small change I would propose is to actually set SQLITE_ENABLE_JSON1 publicly so the client code would be able to test for this feature.

@SRombauts SRombauts merged commit 36cf2cb into SRombauts:master Aug 3, 2020
@richardhozak
Copy link
Contributor Author

It seems that it has been available since sqlite version 3.9.0 as seen in changelog https://sqlite.org/search?s=c&q=JSON1

@SRombauts
Copy link
Owner

See PR #428 for the new branch I just pushed:
I am going to remove option SQLITE_ENABLE_JSON1 since the JSON functions and operators are built into SQLite by default, as of SQLite version 3.38.0 (2022-02-22).

For us with SQLiteCpp it would be since Version 3.2.0 - 2022 September 18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants