Derive Debug and PartialEq on a few more types #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Particularly StrongPtr
SSheldon
approved these changes
May 2, 2021
There was a problem hiding this comment.
Thank you, this looks good! I'll make sure it's included in the next release.
The release situation on objc is a bit messy; I was planning for master to be a new major bump, but haven't gotten around to preparing everything for that. I could backport this to a 0.2.x release to get it out sooner. Let me know if you have any thoughts on this.
|
No need to hurry, I don't need this soon 😉 |
80 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular makes it easier to use
StrongPtr