Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace use of std::function with adiar::... aliases #541

Merged
merged 3 commits into from
Sep 25, 2023
Merged

Conversation

SSoelvsten
Copy link
Owner

@SSoelvsten SSoelvsten commented Sep 25, 2023

Closes #540 and moves test cases in preparation of #539 .

@SSoelvsten SSoelvsten added the ✨ code quality Uncle Bob would be proud label Sep 25, 2023
@SSoelvsten SSoelvsten self-assigned this Sep 25, 2023
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (19f4727) 97.101% compared to head (7619d2d) 97.100%.

Additional details and impacted files
@@              Coverage Diff              @@
##              main      #541       +/-   ##
=============================================
- Coverage   97.101%   97.100%   -0.001%     
=============================================
  Files           81        82        +1     
  Lines         5588      5587        -1     
=============================================
- Hits          5426      5425        -1     
  Misses         162       162               
Files Coverage Δ
src/adiar/bdd.h 100.000% <100.000%> (ø)
src/adiar/bdd/bdd.cpp 87.356% <100.000%> (ø)
src/adiar/bdd/build.cpp 100.000% <100.000%> (ø)
src/adiar/bdd/evaluate.cpp 100.000% <100.000%> (ø)
src/adiar/bdd/quantify.cpp 100.000% <100.000%> (ø)
src/adiar/bool_op.h 100.000% <ø> (ø)
src/adiar/domain.cpp 100.000% <100.000%> (ø)
src/adiar/domain.h 100.000% <100.000%> (ø)
src/adiar/functional.h 100.000% <100.000%> (ø)
src/adiar/internal/algorithms/build.h 100.000% <ø> (ø)
... and 19 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

Benchmark Report 🟢

origin/api/functional is an improvement of 1.07% (compared to origin/main).

Minimum running time (s) for 9-Queens:

origin/main origin/api/functional
0.24 0.24
Raw Data

Running times (s) for 9-Queens:

origin/main origin/api/functional
0.25 0.25
0.25 0.24
0.25 0.25
0.25 0.30
0.25 0.25
0.25 0.25
0.25 0.25
0.25 0.25
0.31 0.30
0.25 0.25
0.25 0.25
0.24 0.25
0.25 0.25
0.25 0.24
0.25 0.25
0.25 0.25

@github-actions
Copy link

Benchmark Report 🟢

origin/api/functional is an improvement of 0.09% (compared to origin/main).

Minimum running time (s) for 12-Queens:

origin/main origin/api/functional
15.20 15.19
Raw Data

Running times (s) for 12-Queens:

origin/main origin/api/functional
15.27 15.23
15.23 15.20
15.25 15.86
15.20 15.28
15.24 15.23
15.24 15.30
15.29 15.23
15.21 15.21
15.23 15.25
15.24 15.22
15.28 15.26
15.27 15.22
15.26 15.19
15.26 15.33
15.21 15.28
15.25 15.20

@github-actions
Copy link

Benchmark Report 🟢

origin/api/functional is a regression of 0.50% (compared to origin/main).

Minimum running time (s) for 14-Queens:

origin/main origin/api/functional
443.57 445.81
Raw Data

Running times (s) for 14-Queens:

origin/main origin/api/functional
591.42 448.42
449.30 446.68
450.80 448.21
443.57 445.81

@SSoelvsten SSoelvsten merged commit 4f38565 into main Sep 25, 2023
43 of 50 checks passed
@SSoelvsten SSoelvsten deleted the api/functional branch October 9, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ code quality Uncle Bob would be proud
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type Aliases for Generators and Predicates
1 participant