Api/naming scheme

[SSoelvsten]

More clean-up of the public API in anticipation for the release of v2.0 . This moves the final few internal pieces of Adiar into the adiar::internal namespace, defines a naming scheme, and enforces this naming scheme across the public API.

• Closes Make boolean operator predicates part of adiar::internal. #544
• Closes Move cut logic into cut_type  #543
• Closes Fix naming scheme of BDD and ZDD predicates #539

[SSoelvsten]

Still missing tasks:

• Fix naming scheme for global enum settings ( irrelevant due to Replace global enums with Execution Policies #546 )
• Fix compilation of examples.

[codecov]

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (4f38565) 97.100% compared to head (bc0d5e2) 96.907%.

❗ Current head bc0d5e2 differs from pull request most recent head 5fcdcd6. Consider uploading reports for the commit 5fcdcd6 to get more accurate results

Additional details and impacted files

@@              Coverage Diff              @@
##              main      #545       +/-   ##
=============================================
- Coverage   97.100%   96.907%   -0.193%     
=============================================
  Files           82        83        +1     
  Lines         5587      5626       +39     
=============================================
+ Hits          5425      5452       +27     
- Misses         162       174       +12     

Files	Coverage Δ
src/adiar/adiar.cpp	93.548% <100.000%> (+0.445%)	⬆️
src/adiar/bdd.h	100.000% <100.000%> (ø)
src/adiar/bdd/apply.cpp	100.000% <100.000%> (ø)
src/adiar/bdd/bdd_policy.h	100.000% <100.000%> (ø)
src/adiar/bdd/build.cpp	100.000% <100.000%> (ø)
src/adiar/bdd/count.cpp	100.000% <100.000%> (ø)
src/adiar/bdd/evaluate.cpp	100.000% <100.000%> (ø)
src/adiar/bdd/if_then_else.cpp	96.140% <100.000%> (ø)
src/adiar/bdd/pred.cpp	100.000% <100.000%> (ø)
src/adiar/bdd/quantify.cpp	100.000% <100.000%> (ø)
... and 69 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Benchmark Report 🟢

origin/api/naming-scheme is a regression of 0.70% (compared to origin/main).

Minimum running time (s) for 14-Queens:

origin/main	origin/api/naming-scheme
422.14	425.09

Raw Data

Running times (s) for 14-Queens:

origin/main	origin/api/naming-scheme
574.73	433.82
429.24	425.09
422.14	429.83
422.24	428.72

[github-actions]

Benchmark Report 🟡

origin/api/naming-scheme is a regression of 3.22% (compared to origin/main).

Minimum running time (s) for 9-Queens:

origin/main	origin/api/naming-scheme
0.31	0.32

Raw Data

Running times (s) for 9-Queens:

origin/main	origin/api/naming-scheme
0.34	0.36
0.33	0.34
0.31	0.35
0.35	0.36
0.31	0.37
0.32	0.34
0.33	0.34
0.33	0.32
0.33	0.32
0.35	0.33
0.34	0.34
0.43	0.35
0.35	0.36
0.35	0.37
0.36	0.35
0.34	0.32

[github-actions]

Benchmark Report 🟢

origin/api/naming-scheme is an improvement of 2.90% (compared to origin/main).

Minimum running time (s) for 12-Queens:

origin/main	origin/api/naming-scheme
15.37	14.93

Raw Data

Running times (s) for 12-Queens:

origin/main	origin/api/naming-scheme
16.70	17.05
17.34	18.58
16.85	17.07
16.09	15.92
16.51	18.18
17.47	15.45
15.84	15.41
15.66	16.64
16.93	16.30
16.46	17.07
15.37	16.30
15.51	14.93
15.62	15.87
16.80	16.07
15.72	16.17
16.16	15.19