Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api/fix support visibility #562

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Api/fix support visibility #562

merged 3 commits into from
Nov 2, 2023

Conversation

SSoelvsten
Copy link
Owner

Closes the breaking parts of #552 .

User's are used to this function being called 'support' and so they very much
might miss we already provide it.
@SSoelvsten SSoelvsten added the ❕ breaking version_number++ label Nov 2, 2023
@SSoelvsten SSoelvsten added this to the v2.0 : API Revamp milestone Nov 2, 2023
@SSoelvsten SSoelvsten self-assigned this Nov 2, 2023
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b666fbd) 96.653% compared to head (c430dc2) 96.653%.

❗ Current head c430dc2 differs from pull request most recent head 1e4dc87. Consider uploading reports for the commit 1e4dc87 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #562   +/-   ##
=========================================
  Coverage   96.653%   96.653%           
=========================================
  Files           83        83           
  Lines         5767      5767           
=========================================
  Hits          5574      5574           
  Misses         193       193           
Files Coverage Δ
src/adiar/bdd.h 100.000% <100.000%> (ø)
src/adiar/bdd/bdd.cpp 86.022% <100.000%> (ø)
src/adiar/internal/algorithms/intercut.h 98.305% <100.000%> (ø)
src/adiar/internal/dd_func.h 90.476% <100.000%> (ø)
src/adiar/zdd.h 100.000% <100.000%> (ø)
src/adiar/zdd/zdd.cpp 76.415% <100.000%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SSoelvsten SSoelvsten merged commit 3952968 into main Nov 2, 2023
41 of 48 checks passed
Copy link

github-actions bot commented Nov 2, 2023

Benchmark Report 🟢

origin/api/fix-support-visibility is a regression of 0.61% (compared to origin/main).

Minimum running time (s) for 9-Queens:

origin/main origin/api/fix-support-visibility
0.23 0.23
Raw Data

Running times (s) for 9-Queens:

origin/main origin/api/fix-support-visibility
0.23 0.23
0.23 0.23
0.23 0.23
0.23 0.23
0.24 0.23
0.24 0.23
0.23 0.23
0.23 0.23
0.24 0.23
0.23 0.23
0.23 0.24
0.23 0.23
0.23 0.24
0.23 0.23
0.23 0.23
0.26 0.24

Copy link

github-actions bot commented Nov 2, 2023

Benchmark Report 🟢

origin/api/fix-support-visibility is a regression of 0.06% (compared to origin/main).

Minimum running time (s) for 12-Queens:

origin/main origin/api/fix-support-visibility
15.00 15.00
Raw Data

Running times (s) for 12-Queens:

origin/main origin/api/fix-support-visibility
15.05 15.11
15.05 15.01
15.10 15.05
15.10 15.10
15.15 15.09
15.10 15.03
15.01 15.06
15.12 15.06
15.08 15.15
15.23 15.14
15.05 15.08
15.10 15.02
15.04 15.07
15.12 15.10
15.05 15.00
15.00 15.12

Copy link

github-actions bot commented Nov 2, 2023

Benchmark Report 🟢

origin/api/fix-support-visibility is a regression of 0.44% (compared to origin/main).

Minimum running time (s) for 14-Queens:

origin/main origin/api/fix-support-visibility
432.68 434.59
Raw Data

Running times (s) for 14-Queens:

origin/main origin/api/fix-support-visibility
585.17 434.59
432.68 439.54
433.55 436.69
440.05 436.83

@SSoelvsten SSoelvsten deleted the api/fix-support-visibility branch November 5, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❕ breaking version_number++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant