Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BDD / Cube #580

Merged
merged 4 commits into from
Nov 17, 2023
Merged

BDD / Cube #580

merged 4 commits into from
Nov 17, 2023

Conversation

SSoelvsten
Copy link
Owner

Closes #533 .

@SSoelvsten SSoelvsten added ✨ feature New operation or other feature 📁 bdd Binary Decision Diagrams ✨ code quality Uncle Bob would be proud labels Nov 17, 2023
@SSoelvsten SSoelvsten self-assigned this Nov 17, 2023
@SSoelvsten SSoelvsten changed the title Bdd/cube BDD / Cube Nov 17, 2023
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5ba29d9) 96.947% compared to head (6946b7a) 96.948%.

Additional details and impacted files
@@              Coverage Diff              @@
##              main      #580       +/-   ##
=============================================
+ Coverage   96.947%   96.948%   +0.001%     
=============================================
  Files           84        84               
  Lines         5864      5865        +1     
=============================================
+ Hits          5685      5686        +1     
  Misses         179       179               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SSoelvsten SSoelvsten merged commit 96e306d into main Nov 17, 2023
36 of 50 checks passed
@SSoelvsten SSoelvsten deleted the bdd/cube branch November 17, 2023 21:04
Copy link

Benchmark Report 🟢

origin/bdd/cube is a regression of 0.25% (compared to origin/main).

Minimum running time (s) for 9-Queens:

origin/main origin/bdd/cube
0.23 0.23
Raw Data

Running times (s) for 9-Queens:

origin/main origin/bdd/cube
0.23 0.23
0.23 0.23
0.23 0.24
0.24 0.24
0.23 0.23
0.24 0.25
0.23 0.23
0.26 0.23
0.23 0.23
0.23 0.23
0.23 0.24
0.23 0.23
0.23 0.23
0.23 0.23
0.23 0.24
0.23 0.25

Copy link

Benchmark Report 🟢

origin/bdd/cube is an improvement of 0.18% (compared to origin/main).

Minimum running time (s) for 12-Queens:

origin/main origin/bdd/cube
11.48 11.46
Raw Data

Running times (s) for 12-Queens:

origin/main origin/bdd/cube
11.65 11.50
11.52 11.51
11.55 11.47
11.49 11.57
11.52 11.50
11.51 11.46
11.48 11.52
11.57 11.53
11.60 11.46
11.55 11.53
11.51 11.48
11.54 11.57
11.65 11.54
11.58 11.54
11.60 11.54
11.60 11.61

Copy link

Benchmark Report 🟢

origin/bdd/cube is an improvement of 0.47% (compared to origin/main).

Minimum running time (s) for 14-Queens:

origin/main origin/bdd/cube
271.48 270.21
Raw Data

Running times (s) for 14-Queens:

origin/main origin/bdd/cube
382.79 271.01
273.84 273.59
272.88 270.21
271.48 271.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📁 bdd Binary Decision Diagrams ✨ code quality Uncle Bob would be proud ✨ feature New operation or other feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add bdd_iscube and bdd_cube
1 participant