Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal/DOT without ids #603

Merged
merged 8 commits into from
Jan 5, 2024
Merged

Internal/DOT without ids #603

merged 8 commits into from
Jan 5, 2024

Conversation

SSoelvsten
Copy link
Owner

@SSoelvsten SSoelvsten commented Jan 5, 2024

Closes #602 and also improves the code-base / fixes tiny bugs I visited.

While doing so, I also:
- Moved the internal algorithm into the algorithms folder
- Moved the compilation unit to its own file in the BDD and ZDD folders
This (1) decreases the size of each node slightly and (2) better matches with the paper
@SSoelvsten SSoelvsten added ✨ feature New operation or other feature 📁 bdd Binary Decision Diagrams 📁 zdd Zero-suppressed Decision Diagrams ✨ code quality Uncle Bob would be proud labels Jan 5, 2024
@SSoelvsten SSoelvsten self-assigned this Jan 5, 2024
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eb71a31) 97.033% compared to head (297a50d) 97.033%.

Additional details and impacted files
@@              Coverage Diff              @@
##              main      #603       +/-   ##
=============================================
- Coverage   97.033%   97.033%   -0.000%     
=============================================
  Files           84        88        +4     
  Lines         6168      6167        -1     
=============================================
- Hits          5985      5984        -1     
  Misses         183       183               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 5, 2024

🟡 Regression Test (Picotrav 'adder')

'origin/internal/dot' is a change in performance of -0.95% (stdev: 1.41%).

... origin/main origin/internal/dot
Mean 9324.80 9413.80
Standard Deviation 131.39 78.73

Number of samples: 5

Copy link

github-actions bot commented Jan 5, 2024

🟢 Regression Test (QBF 'breakthrough/3x5_11_bwnib')

'origin/internal/dot' is a change in performance of 0.07% (stdev: 1.66%).

... origin/main origin/internal/dot
Mean 12947.20 12937.60
Standard Deviation 215.43 48.36

Number of samples: 5

Copy link

github-actions bot commented Jan 5, 2024

🟢 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')

'origin/internal/dot' is a change in performance of 1.83% (stdev: 4.60%).

... origin/main origin/internal/dot
Mean 17176.60 16862.40
Standard Deviation 790.42 131.19

Number of samples: 5

Copy link

github-actions bot commented Jan 5, 2024

🟢 Regression Test (QBF 'domineering/5x5_13_bwnib')

'origin/internal/dot' is a change in performance of 0.78% (stdev: 3.16%).

... origin/main origin/internal/dot
Mean 42457.40 42124.20
Standard Deviation 1343.59 181.48

Number of samples: 5

Copy link

github-actions bot commented Jan 5, 2024

🔴 Regression Test (QBF 'breakthrough/3x4_19_bwnib')

'origin/internal/dot' is a change in performance of -1.20% (stdev: 0.56%).

... origin/main origin/internal/dot
Mean 46089.80 46644.60
Standard Deviation 197.83 259.84

Number of samples: 5

Copy link

github-actions bot commented Jan 5, 2024

🟡 Regression Test (Picotrav 'mem_ctrl')

'origin/internal/dot' is a change in performance of -0.26% (stdev: 0.65%).

... origin/main origin/internal/dot
Mean 111763.75 112055.25
Standard Deviation 721.33 383.79

Number of samples: 4

Copy link

github-actions bot commented Jan 5, 2024

🟡 Regression Test (Picotrav 'arbiter')

'origin/internal/dot' is a change in performance of -0.70% (stdev: 14.45%).

... origin/main origin/internal/dot
Mean 65948.90 66413.60
Standard Deviation 9530.34 9592.00

Number of samples: 10

@SSoelvsten SSoelvsten added the 🔥 bug Something isn't working label Jan 5, 2024
@SSoelvsten SSoelvsten merged commit f167e35 into main Jan 5, 2024
53 checks passed
Copy link

github-actions bot commented Jan 5, 2024

🟢 Regression Test (QBF 'domineering/5x5_13_bwnib')

'origin/internal/dot' is a change in performance of 0.61% (stdev: 3.76%).

... origin/main origin/internal/dot
Mean 42885.75 42626.25
Standard Deviation 1614.39 82.85

Number of samples: 4

Copy link

github-actions bot commented Jan 5, 2024

🟡 Regression Test (QBF 'breakthrough/3x4_19_bwnib')

'origin/internal/dot' is a change in performance of -0.90% (stdev: 0.93%).

... origin/main origin/internal/dot
Mean 46373.00 46788.25
Standard Deviation 433.54 234.43

Number of samples: 4

Copy link

github-actions bot commented Jan 5, 2024

🟢 Regression Test (QBF 'breakthrough/3x5_11_bwnib')

'origin/internal/dot' is a change in performance of 0.42% (stdev: 0.95%).

... origin/main origin/internal/dot
Mean 12902.80 12849.20
Standard Deviation 122.34 43.48

Number of samples: 5

Copy link

github-actions bot commented Jan 5, 2024

🟢 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')

'origin/internal/dot' is a change in performance of 1.05% (stdev: 3.01%).

... origin/main origin/internal/dot
Mean 16880.20 16703.60
Standard Deviation 507.74 211.03

Number of samples: 5

Copy link

github-actions bot commented Jan 5, 2024

🟡 Regression Test (Picotrav 'mem_ctrl')

'origin/internal/dot' is a change in performance of -0.32% (stdev: 0.64%).

... origin/main origin/internal/dot
Mean 112963.25 113319.75
Standard Deviation 728.45 232.76

Number of samples: 4

Copy link

github-actions bot commented Jan 5, 2024

🟡 Regression Test (Picotrav 'adder')

'origin/internal/dot' is a change in performance of -2.97% (stdev: 8.65%).

... origin/main origin/internal/dot
Mean 9159.20 9431.60
Standard Deviation 63.72 815.85

Number of samples: 10

Copy link

github-actions bot commented Jan 5, 2024

🟢 Regression Test (Picotrav 'arbiter')

'origin/internal/dot' is a change in performance of 3.70% (stdev: 14.04%).

... origin/main origin/internal/dot
Mean 65670.20 63243.60
Standard Deviation 9217.75 555.46

Number of samples: 10

@SSoelvsten SSoelvsten deleted the internal/dot branch January 9, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📁 bdd Binary Decision Diagrams 🔥 bug Something isn't working ✨ code quality Uncle Bob would be proud ✨ feature New operation or other feature 📁 zdd Zero-suppressed Decision Diagrams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dot files for better images
1 participant