-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internal/DOT without ids #603
Conversation
While doing so, I also: - Moved the internal algorithm into the algorithms folder - Moved the compilation unit to its own file in the BDD and ZDD folders
This (1) decreases the size of each node slightly and (2) better matches with the paper
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #603 +/- ##
=============================================
- Coverage 97.033% 97.033% -0.000%
=============================================
Files 84 88 +4
Lines 6168 6167 -1
=============================================
- Hits 5985 5984 -1
Misses 183 183 ☔ View full report in Codecov by Sentry. |
🟡 Regression Test (Picotrav 'adder')'origin/internal/dot' is a change in performance of -0.95% (stdev: 1.41%).
Number of samples: 5 |
🟢 Regression Test (QBF 'breakthrough/3x5_11_bwnib')'origin/internal/dot' is a change in performance of 0.07% (stdev: 1.66%).
Number of samples: 5 |
🟢 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')'origin/internal/dot' is a change in performance of 1.83% (stdev: 4.60%).
Number of samples: 5 |
🟢 Regression Test (QBF 'domineering/5x5_13_bwnib')'origin/internal/dot' is a change in performance of 0.78% (stdev: 3.16%).
Number of samples: 5 |
🔴 Regression Test (QBF 'breakthrough/3x4_19_bwnib')'origin/internal/dot' is a change in performance of -1.20% (stdev: 0.56%).
Number of samples: 5 |
🟡 Regression Test (Picotrav 'mem_ctrl')'origin/internal/dot' is a change in performance of -0.26% (stdev: 0.65%).
Number of samples: 4 |
🟡 Regression Test (Picotrav 'arbiter')'origin/internal/dot' is a change in performance of -0.70% (stdev: 14.45%).
Number of samples: 10 |
This matches the formatting in our papers and in Knuth's book
🟢 Regression Test (QBF 'domineering/5x5_13_bwnib')'origin/internal/dot' is a change in performance of 0.61% (stdev: 3.76%).
Number of samples: 4 |
🟡 Regression Test (QBF 'breakthrough/3x4_19_bwnib')'origin/internal/dot' is a change in performance of -0.90% (stdev: 0.93%).
Number of samples: 4 |
🟢 Regression Test (QBF 'breakthrough/3x5_11_bwnib')'origin/internal/dot' is a change in performance of 0.42% (stdev: 0.95%).
Number of samples: 5 |
🟢 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')'origin/internal/dot' is a change in performance of 1.05% (stdev: 3.01%).
Number of samples: 5 |
🟡 Regression Test (Picotrav 'mem_ctrl')'origin/internal/dot' is a change in performance of -0.32% (stdev: 0.64%).
Number of samples: 4 |
🟡 Regression Test (Picotrav 'adder')'origin/internal/dot' is a change in performance of -2.97% (stdev: 8.65%).
Number of samples: 10 |
🟢 Regression Test (Picotrav 'arbiter')'origin/internal/dot' is a change in performance of 3.70% (stdev: 14.04%).
Number of samples: 10 |
Closes #602 and also improves the code-base / fixes tiny bugs I visited.