Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal/prod2/increase ra threshold #606

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

SSoelvsten
Copy link
Owner

Proper follow-up up to close #495 .

@SSoelvsten SSoelvsten added the ✨ optimisation It's all about speed / space label Jan 12, 2024
@SSoelvsten SSoelvsten self-assigned this Jan 12, 2024
The previous one seems to not be maintained and now is broken.
@SSoelvsten SSoelvsten force-pushed the internal/prod2/increase_ra-threshold branch from 26ccf97 to 8f572fa Compare January 12, 2024 09:48
Copy link

🟢 Regression Test (QBF 'breakthrough/3x5_11_bwnib')

'origin/internal/prod2/increase_ra-threshold' is a change in performance of 0.26% (stdev: 0.65%).

... origin/main origin/internal/prod2/increase_ra-threshold
Mean 12922.80 12889.00
Standard Deviation 84.34 43.78

Number of samples: 5

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ed5a0ca) 97.032% compared to head (8f572fa) 97.035%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##              main      #606       +/-   ##
=============================================
+ Coverage   97.032%   97.035%   +0.003%     
=============================================
  Files           88        88               
  Lines         6166      6173        +7     
=============================================
+ Hits          5983      5990        +7     
  Misses         183       183               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

🟢 Regression Test (QBF 'breakthrough/3x5_11_bwnib')

'origin/internal/prod2/increase_ra-threshold' is a change in performance of 0.55% (stdev: 1.12%).

... origin/main origin/internal/prod2/increase_ra-threshold
Mean 12958.40 12886.60
Standard Deviation 145.13 14.36

Number of samples: 5

Copy link

🟢 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')

'origin/internal/prod2/increase_ra-threshold' is a change in performance of 1.25% (stdev: 3.47%).

... origin/main origin/internal/prod2/increase_ra-threshold
Mean 17142.20 16927.40
Standard Deviation 594.53 131.85

Number of samples: 5

Copy link

🟢 Regression Test (QBF 'domineering/5x5_13_bwnib')

'origin/internal/prod2/increase_ra-threshold' is a change in performance of 1.50% (stdev: 2.81%).

... origin/main origin/internal/prod2/increase_ra-threshold
Mean 43020.00 42375.00
Standard Deviation 1210.04 38.16

Number of samples: 5

Copy link

🟢 Regression Test (QBF 'breakthrough/3x4_19_bwnib')

'origin/internal/prod2/increase_ra-threshold' is a change in performance of 0.04% (stdev: 0.32%).

... origin/main origin/internal/prod2/increase_ra-threshold
Mean 46770.60 46752.20
Standard Deviation 85.59 147.82

Number of samples: 5

Copy link

🟢 Regression Test (Picotrav 'adder')

'origin/internal/prod2/increase_ra-threshold' is a change in performance of 0.57% (stdev: 1.24%).

... origin/main origin/internal/prod2/increase_ra-threshold
Mean 9367.80 9314.40
Standard Deviation 115.89 53.93

Number of samples: 10

Copy link

🟡 Regression Test (Picotrav 'mem_ctrl')

'origin/internal/prod2/increase_ra-threshold' is a change in performance of -0.09% (stdev: 0.60%).

... origin/main origin/internal/prod2/increase_ra-threshold
Mean 112882.40 112985.80
Standard Deviation 680.16 121.62

Number of samples: 5

Copy link

🟢 Regression Test (Picotrav 'arbiter')

'origin/internal/prod2/increase_ra-threshold' is a change in performance of 4.64% (stdev: 14.20%).

... origin/main origin/internal/prod2/increase_ra-threshold
Mean 65789.60 62736.50
Standard Deviation 9341.94 286.15

Number of samples: 10

@SSoelvsten SSoelvsten merged commit 00cacd7 into main Jan 12, 2024
53 checks passed
@SSoelvsten SSoelvsten deleted the internal/prod2/increase_ra-threshold branch January 12, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ optimisation It's all about speed / space
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Random-Access Threshold based on Experiments
1 participant