Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format src/ and test/ #610

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Format src/ and test/ #610

merged 2 commits into from
Feb 13, 2024

Conversation

SSoelvsten
Copy link
Owner

@SSoelvsten SSoelvsten commented Feb 12, 2024

use Clang Format on entire code base. Since this was started by Erik Funder Carstensen , I authored the commit as such .

@SSoelvsten SSoelvsten added 📁 build CMake, GitHub Actions etc. ✨ code quality Uncle Bob would be proud labels Feb 12, 2024
@SSoelvsten SSoelvsten self-assigned this Feb 12, 2024
This value is unknown to the CI job
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 43 lines in your changes are missing coverage. Please review.

Comparison is base (47bdee6) 97.142% compared to head (93be1ac) 97.185%.

Files Patch % Lines
src/adiar/bdd/apply.cpp 78.947% 8 Missing ⚠️
src/adiar/internal/algorithms/count.h 83.871% 5 Missing ⚠️
src/adiar/internal/algorithms/nested_sweeping.h 97.788% 5 Missing ⚠️
src/adiar/internal/io/file.h 88.235% 4 Missing ⚠️
src/adiar/bdd/bdd.cpp 93.617% 3 Missing ⚠️
src/adiar/internal/algorithms/select.h 91.176% 3 Missing ⚠️
src/adiar/internal/dd.h 94.340% 3 Missing ⚠️
src/adiar/bdd/if_then_else.cpp 98.148% 2 Missing ⚠️
src/adiar/internal/algorithms/pred.h 95.000% 2 Missing ⚠️
src/adiar/internal/algorithms/prod2.h 98.425% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@              Coverage Diff              @@
##              main      #610       +/-   ##
=============================================
+ Coverage   97.142%   97.185%   +0.043%     
=============================================
  Files           88        88               
  Lines         6264      6111      -153     
=============================================
- Hits          6085      5939      -146     
+ Misses         179       172        -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

🟡 Regression Test (Picotrav 'mem_ctrl')

'origin/clang-format' is a change in performance of -0.92% (stdev: 1.01%).

... origin/main origin/clang-format
Mean 113290.33 114330.33
Standard Deviation 1147.69 427.29

Number of samples: 3

Copy link

🟢 Regression Test (QBF 'breakthrough/3x5_11_bwnib')

'origin/clang-format' is a change in performance of 0.27% (stdev: 1.20%).

... origin/main origin/clang-format
Mean 9954.20 9927.00
Standard Deviation 119.81 85.25

Number of samples: 5

Copy link

🟡 Regression Test (Picotrav 'arbiter')

'origin/clang-format' is a change in performance of -0.42% (stdev: 0.97%).

... origin/main origin/clang-format
Mean 62643.75 62907.50
Standard Deviation 607.32 142.41

Number of samples: 4

Copy link

🟢 Regression Test (QBF 'breakthrough/3x4_19_bwnib')

'origin/clang-format' is a change in performance of 0.90% (stdev: 0.53%).

... origin/main origin/clang-format
Mean 28897.80 28637.40
Standard Deviation 153.01 75.96

Number of samples: 5

Copy link

🟢 Regression Test (QBF 'domineering/5x5_13_bwnib')

'origin/clang-format' is a change in performance of 1.45% (stdev: 4.15%).

... origin/main origin/clang-format
Mean 31081.80 30632.60
Standard Deviation 1289.28 331.48

Number of samples: 5

Copy link

🟡 Regression Test (Picotrav 'adder')

'origin/clang-format' is a change in performance of -3.06% (stdev: 8.92%).

... origin/main origin/clang-format
Mean 9212.30 9494.10
Standard Deviation 68.80 846.41

Number of samples: 10

Copy link

🟢 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')

'origin/clang-format' is a change in performance of 2.04% (stdev: 5.81%).

... origin/main origin/clang-format
Mean 44790.60 43878.90
Standard Deviation 2601.44 284.65

Number of samples: 10

@SSoelvsten SSoelvsten merged commit ac7b771 into main Feb 13, 2024
54 checks passed
@SSoelvsten SSoelvsten deleted the clang-format branch February 13, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📁 build CMake, GitHub Actions etc. ✨ code quality Uncle Bob would be proud
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants