-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Readd shallow variables heuristic #621
WIP: Readd shallow variables heuristic #621
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #621 +/- ##
=============================================
+ Coverage 97.225% 97.232% +0.007%
=============================================
Files 90 90
Lines 6343 6358 +15
=============================================
+ Hits 6167 6182 +15
Misses 176 176 ☔ View full report in Codecov by Sentry. |
🟡 Regression Test (QBF 'breakthrough/3x4_19_bwnib')'origin/internal/quantify/shallow_variables_heuristic' is a change in performance of -0.07% (stdev: 1.76%).
Number of samples: 4 |
🟢 Regression Test (Picotrav 'mem_ctrl')'origin/internal/quantify/shallow_variables_heuristic' is a change in performance of 1.37% (stdev: 2.64%).
Number of samples: 3 |
🟢 Regression Test (QBF 'breakthrough/3x5_11_bwnib')'origin/internal/quantify/shallow_variables_heuristic' is a change in performance of 1.22% (stdev: 1.63%).
Number of samples: 5 |
🟡 Regression Test (Picotrav 'arbiter')'origin/internal/quantify/shallow_variables_heuristic' is a change in performance of -0.36% (stdev: 1.28%).
Number of samples: 4 |
🟡 Regression Test (QBF 'domineering/5x5_13_bwnib')'origin/internal/quantify/shallow_variables_heuristic' is a change in performance of -2.44% (stdev: 4.65%).
Number of samples: 6 |
🟡 Regression Test (Picotrav 'adder')'origin/internal/quantify/shallow_variables_heuristic' is a change in performance of -0.03% (stdev: 0.63%).
Number of samples: 5 |
🟢 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')'origin/internal/quantify/shallow_variables_heuristic' is a change in performance of 59.51% (stdev: 8.60%).
Number of samples: 10 |
As can be seen from the above, this heuristic reverts the slowdown in #608 for ep/8x8. Now, the unit tests just need to be updated accordingly to make this mergeable. |
4df091f
to
8c4971a
Compare
8c4971a
to
c98eeb2
Compare
Interestingly this does not seem to fully fix domineering/5x5_13_bwnib. So, we may also want to readd the heuristic based on the number of terminal arcs (or an improved version of it). |
Add the "shallow variables" heuristic anew to revert the slowdown introduced in #608 .