-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readd terminal arcs heuristic #622
Conversation
This is a slightly more (and also less) sophisticated version of the terminal arcs heuristic we had in earlier. Instead of stopping the partial quantification when there are few arcs, we (1) weigh it based on collapsing arcs and (2) compute a maximum number of sweeps based on an exponential function.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #622 +/- ##
=============================================
+ Coverage 97.232% 97.237% +0.006%
=============================================
Files 90 90
Lines 6358 6371 +13
=============================================
+ Hits 6182 6195 +13
Misses 176 176 ☔ View full report in Codecov by Sentry. |
🟢 Regression Test (QBF 'breakthrough/3x5_11_bwnib')'origin/internal/quantify/terminals_heuristic' is a change in performance of 0.18% (stdev: 1.35%).
Number of samples: 9 |
🟢 Regression Test (QBF 'domineering/5x5_13_bwnib')'origin/internal/quantify/terminals_heuristic' is a change in performance of 1.44% (stdev: 4.60%).
Number of samples: 8 |
🟢 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')'origin/internal/quantify/terminals_heuristic' is a change in performance of 1.13% (stdev: 4.17%).
Number of samples: 9 |
🟢 Regression Test (Picotrav 'adder')'origin/internal/quantify/terminals_heuristic' is a change in performance of 0.39% (stdev: 0.69%).
Number of samples: 9 |
🟢 Regression Test (QBF 'breakthrough/3x4_19_bwnib')'origin/internal/quantify/terminals_heuristic' is a change in performance of 0.24% (stdev: 0.78%).
Number of samples: 8 |
🟡 Regression Test (Picotrav 'mem_ctrl')'origin/internal/quantify/terminals_heuristic' is a change in performance of -0.22% (stdev: 0.50%).
Number of samples: 6 |
🟢 Regression Test (Picotrav 'arbiter')'origin/internal/quantify/terminals_heuristic' is a change in performance of 4.33% (stdev: 19.23%).
Number of samples: 10 |
This is a slightly more (and also less) sophisticated version of the terminal arcs heuristic we had in earlier. Instead of stopping the partial quantification when there are few arcs, we (1) weigh it based on collapsing arcs and (2) compute a maximum number of sweeps based on an exponential function.