Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readd terminal arcs heuristic #622

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

SSoelvsten
Copy link
Owner

This is a slightly more (and also less) sophisticated version of the terminal arcs heuristic we had in earlier. Instead of stopping the partial quantification when there are few arcs, we (1) weigh it based on collapsing arcs and (2) compute a maximum number of sweeps based on an exponential function.

This is a slightly more (and also less) sophisticated version of the terminal arcs
heuristic we had in earlier. Instead of stopping the partial quantification when
there are few arcs, we (1) weigh it based on collapsing arcs and (2) compute a
maximum number of sweeps based on an exponential function.
@SSoelvsten SSoelvsten added ✨ optimisation It's all about speed / space 📁 internal This is where the ✨magic✨happens labels Feb 29, 2024
@SSoelvsten SSoelvsten self-assigned this Feb 29, 2024
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.237%. Comparing base (7aa583a) to head (64ef178).

Additional details and impacted files
@@              Coverage Diff              @@
##              main      #622       +/-   ##
=============================================
+ Coverage   97.232%   97.237%   +0.006%     
=============================================
  Files           90        90               
  Lines         6358      6371       +13     
=============================================
+ Hits          6182      6195       +13     
  Misses         176       176               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

🟢 Regression Test (QBF 'breakthrough/3x5_11_bwnib')

'origin/internal/quantify/terminals_heuristic' is a change in performance of 0.18% (stdev: 1.35%).

... origin/main origin/internal/quantify/terminals_heuristic
Mean 7450.22 7436.56
Standard Deviation 100.70 41.42

Number of samples: 9

Copy link

🟢 Regression Test (QBF 'domineering/5x5_13_bwnib')

'origin/internal/quantify/terminals_heuristic' is a change in performance of 1.44% (stdev: 4.60%).

... origin/main origin/internal/quantify/terminals_heuristic
Mean 23255.00 22919.38
Standard Deviation 1070.78 72.50

Number of samples: 8

Copy link

🟢 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')

'origin/internal/quantify/terminals_heuristic' is a change in performance of 1.13% (stdev: 4.17%).

... origin/main origin/internal/quantify/terminals_heuristic
Mean 11601.11 11469.89
Standard Deviation 483.69 65.10

Number of samples: 9

Copy link

🟢 Regression Test (Picotrav 'adder')

'origin/internal/quantify/terminals_heuristic' is a change in performance of 0.39% (stdev: 0.69%).

... origin/main origin/internal/quantify/terminals_heuristic
Mean 9288.00 9251.89
Standard Deviation 64.06 46.59

Number of samples: 9

Copy link

🟢 Regression Test (QBF 'breakthrough/3x4_19_bwnib')

'origin/internal/quantify/terminals_heuristic' is a change in performance of 0.24% (stdev: 0.78%).

... origin/main origin/internal/quantify/terminals_heuristic
Mean 24851.25 24792.50
Standard Deviation 130.95 192.43

Number of samples: 8

Copy link

github-actions bot commented Feb 29, 2024

🟡 Regression Test (Picotrav 'mem_ctrl')

'origin/internal/quantify/terminals_heuristic' is a change in performance of -0.22% (stdev: 0.50%).

... origin/main origin/internal/quantify/terminals_heuristic
Mean 111027.00 111271.33
Standard Deviation 554.18 243.33

Number of samples: 6

Copy link

🟢 Regression Test (Picotrav 'arbiter')

'origin/internal/quantify/terminals_heuristic' is a change in performance of 4.33% (stdev: 19.23%).

... origin/main origin/internal/quantify/terminals_heuristic
Mean 69558.00 66546.10
Standard Deviation 13374.49 9731.91

Number of samples: 10

@SSoelvsten SSoelvsten merged commit 53a193d into main Feb 29, 2024
54 checks passed
@SSoelvsten SSoelvsten deleted the internal/quantify/terminals_heuristic branch February 29, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📁 internal This is where the ✨magic✨happens ✨ optimisation It's all about speed / space
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant