bool_op refactor
#624
Merged
bool_op refactor
#624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSoelvsten
added
✨ optimisation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #624 +/- ##
=============================================
+ Coverage 97.237% 97.306% +0.069%
=============================================
Files 90 90
Lines 6371 6534 +163
=============================================
+ Hits 6195 6358 +163
Misses 176 176 ☔ View full report in Codecov by Sentry. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
🟢 Regression Test (Picotrav 'adder')'origin/bool_op-refactor' is a change in performance of 0.16% (stdev: 0.61%).
Number of samples: 5 |
🟢 Regression Test (Picotrav 'mem_ctrl')'origin/bool_op-refactor' is a change in performance of 0.60% (stdev: 0.85%).
Number of samples: 3 |
This comment was marked as off-topic.
This comment was marked as off-topic.
🟢 Regression Test (Picotrav 'arbiter')'origin/bool_op-refactor' is a change in performance of 0.06% (stdev: 0.79%).
Number of samples: 4 |
SSoelvsten
force-pushed
the
bool_op-refactor
branch
4 times, most recently
from
aae8cbd to
128c142
Compare
- Ensure all lambdas indeed return a 'uid' rather than a 'ptr' - Since the 'uid' already includes the 'essential(...)' this can be removed
If you have a fancy word for it, then you may as well use it.
SSoelvsten
force-pushed
the
bool_op-refactor
branch
from
128c142 to
ea4e9fd
Compare
🟢 Regression Test (12-Queens)'origin/bool_op-refactor' is a change in performance of 1.77% (stdev: 0.97%).
Number of samples: 5 |
Currently, this function is never called with a flagged terminal. Hence, there is no need to actually make the input canonical
🟢 Regression Test (14-Queens)'origin/bool_op-refactor' is a change in performance of 8.14% (stdev: 15.86%).
Number of samples: 6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #162 by ...
predicate<bool, bool>bdd_and(f,g)is not anymore an alias forbdd_apply(f, g, and_op)but a specially compiled version where various if-statements are removed..