Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal/quantify/terminal heuristic (2) #646

Closed
wants to merge 4 commits into from

Conversation

SSoelvsten
Copy link
Owner

@SSoelvsten SSoelvsten commented Apr 3, 2024

A more aggressive version than #645 . Yet, this needs more work, as it breaks unit tests.

It turns out, most of the improvements due to Repeated Transposition happen when doing
so can remove 'shortcut (node)' requests, i.e. when there is a non-shortcutting (but
rather idempotent) terminal.
@SSoelvsten SSoelvsten self-assigned this Apr 3, 2024
@SSoelvsten SSoelvsten added ✨ optimisation It's all about speed / space 📁 internal This is where the ✨magic✨happens labels Apr 3, 2024

This comment was marked as off-topic.

Copy link

github-actions bot commented Apr 3, 2024

🟢 Regression Test (QBF 'domineering/5x5_13_bwnib')

'origin/internal/quantify/terminal_heuristic__2' is a change in performance of 10.30% (stdev: 2.05%).

... origin/main origin/internal/quantify/terminal_heuristic__2
Mean 22079.25 19804.75
Standard Deviation 452.76 269.95

Number of samples: 4

Copy link

github-actions bot commented Apr 3, 2024

🟢 Regression Test (QBF 'breakthrough/3x4_19_bwnib')

'origin/internal/quantify/terminal_heuristic__2' is a change in performance of 0.15% (stdev: 1.53%).

... origin/main origin/internal/quantify/terminal_heuristic__2
Mean 24402.00 24365.33
Standard Deviation 62.75 372.08

Number of samples: 3

Copy link

github-actions bot commented Apr 3, 2024

🟢 Regression Test (QBF 'hex/hein_08_5x5-11_bwnib')

'origin/internal/quantify/terminal_heuristic__2' is a change in performance of 52.51% (stdev: 2.11%).

... origin/main origin/internal/quantify/terminal_heuristic__2
Mean 41630.00 19769.00
Standard Deviation 282.60 417.42

Number of samples: 3

Copy link

github-actions bot commented Apr 3, 2024

🔴 Regression Test (QBF 'breakthrough_dual/3x6_10_bwnib')

'origin/internal/quantify/terminal_heuristic__2' is a change in performance of -51.52% (stdev: 0.65%).

... origin/main origin/internal/quantify/terminal_heuristic__2
Mean 3512.50 5322.25
Standard Deviation 12.37 34.62

Number of samples: 4

Copy link

github-actions bot commented Apr 3, 2024

🟢 Regression Test (Picotrav 'adder')

'origin/internal/quantify/terminal_heuristic__2' is a change in performance of 0.29% (stdev: 0.75%).

... origin/main origin/internal/quantify/terminal_heuristic__2
Mean 9636.25 9608.50
Standard Deviation 72.08 49.33

Number of samples: 4

This comment was marked as off-topic.

Copy link

github-actions bot commented Apr 3, 2024

🟢 Regression Test (QBF 'connect4/6x6_11_connect4_bwnib')

'origin/internal/quantify/terminal_heuristic__2' is a change in performance of 26.99% (stdev: 0.73%).

... origin/main origin/internal/quantify/terminal_heuristic__2
Mean 16889.67 12331.33
Standard Deviation 26.31 89.85

Number of samples: 3

Copy link

github-actions bot commented Apr 3, 2024

🔴 Regression Test (QBF 'ep_dual/8x8_6_e-8-1_p-2-3_bwnib')

'origin/internal/quantify/terminal_heuristic__2' is a change in performance of -19.72% (stdev: 0.69%).

... origin/main origin/internal/quantify/terminal_heuristic__2
Mean 4183.25 5008.25
Standard Deviation 28.69 5.91

Number of samples: 4

Copy link

github-actions bot commented Apr 3, 2024

🟢 Regression Test (QBF 'httt/4x4_9_tippy_bwnib')

'origin/internal/quantify/terminal_heuristic__2' is a change in performance of 38.91% (stdev: 0.72%).

... origin/main origin/internal/quantify/terminal_heuristic__2
Mean 17245.00 10534.25
Standard Deviation 103.67 75.48

Number of samples: 4

Copy link

github-actions bot commented Apr 3, 2024

🔴 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')

'origin/internal/quantify/terminal_heuristic__2' is a change in performance of -158.44% (stdev: 0.85%).

... origin/main origin/internal/quantify/terminal_heuristic__2
Mean 11412.67 29494.33
Standard Deviation 29.50 250.68

Number of samples: 3

This comment was marked as off-topic.

@SSoelvsten SSoelvsten force-pushed the internal/quantify/terminal_heuristic__2 branch from 581f383 to 009340f Compare April 3, 2024 10:49

This comment was marked as off-topic.

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.153%. Comparing base (e3ab240) to head (b083cb6).

Additional details and impacted files
@@              Coverage Diff              @@
##              main      #646       +/-   ##
=============================================
- Coverage   97.315%   96.153%   -1.162%     
=============================================
  Files           90        90               
  Lines         6480      6498       +18     
=============================================
- Hits          6306      6248       -58     
- Misses         174       250       +76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SSoelvsten SSoelvsten force-pushed the internal/quantify/terminal_heuristic__2 branch 4 times, most recently from 13ef1f5 to e5f9045 Compare April 3, 2024 13:32
@SSoelvsten SSoelvsten force-pushed the internal/quantify/terminal_heuristic__2 branch from e5f9045 to b083cb6 Compare April 3, 2024 13:51
@SSoelvsten SSoelvsten closed this Apr 4, 2024
@SSoelvsten SSoelvsten deleted the internal/quantify/terminal_heuristic__2 branch April 4, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📁 internal This is where the ✨magic✨happens ✨ optimisation It's all about speed / space
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant