-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internal/quantify/terminal heuristic (2) #646
Conversation
It turns out, most of the improvements due to Repeated Transposition happen when doing so can remove 'shortcut (node)' requests, i.e. when there is a non-shortcutting (but rather idempotent) terminal.
This comment was marked as off-topic.
This comment was marked as off-topic.
🟢 Regression Test (QBF 'domineering/5x5_13_bwnib')'origin/internal/quantify/terminal_heuristic__2' is a change in performance of 10.30% (stdev: 2.05%).
Number of samples: 4 |
🟢 Regression Test (QBF 'breakthrough/3x4_19_bwnib')'origin/internal/quantify/terminal_heuristic__2' is a change in performance of 0.15% (stdev: 1.53%).
Number of samples: 3 |
🟢 Regression Test (QBF 'hex/hein_08_5x5-11_bwnib')'origin/internal/quantify/terminal_heuristic__2' is a change in performance of 52.51% (stdev: 2.11%).
Number of samples: 3 |
🔴 Regression Test (QBF 'breakthrough_dual/3x6_10_bwnib')'origin/internal/quantify/terminal_heuristic__2' is a change in performance of -51.52% (stdev: 0.65%).
Number of samples: 4 |
🟢 Regression Test (Picotrav 'adder')'origin/internal/quantify/terminal_heuristic__2' is a change in performance of 0.29% (stdev: 0.75%).
Number of samples: 4 |
This comment was marked as off-topic.
This comment was marked as off-topic.
🟢 Regression Test (QBF 'connect4/6x6_11_connect4_bwnib')'origin/internal/quantify/terminal_heuristic__2' is a change in performance of 26.99% (stdev: 0.73%).
Number of samples: 3 |
🔴 Regression Test (QBF 'ep_dual/8x8_6_e-8-1_p-2-3_bwnib')'origin/internal/quantify/terminal_heuristic__2' is a change in performance of -19.72% (stdev: 0.69%).
Number of samples: 4 |
🟢 Regression Test (QBF 'httt/4x4_9_tippy_bwnib')'origin/internal/quantify/terminal_heuristic__2' is a change in performance of 38.91% (stdev: 0.72%).
Number of samples: 4 |
🔴 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')'origin/internal/quantify/terminal_heuristic__2' is a change in performance of -158.44% (stdev: 0.85%).
Number of samples: 3 |
This comment was marked as off-topic.
This comment was marked as off-topic.
581f383
to
009340f
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #646 +/- ##
=============================================
- Coverage 97.315% 96.153% -1.162%
=============================================
Files 90 90
Lines 6480 6498 +18
=============================================
- Hits 6306 6248 -58
- Misses 174 250 +76 ☔ View full report in Codecov by Sentry. |
13ef1f5
to
e5f9045
Compare
e5f9045
to
b083cb6
Compare
A more aggressive version than #645 . Yet, this needs more work, as it breaks unit tests.