Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal/quantify/terminal heuristic (4) #648

Closed
wants to merge 2 commits into from

Conversation

SSoelvsten
Copy link
Owner

@SSoelvsten SSoelvsten commented Apr 4, 2024

Changes

  • It now only cares about the shortcutting terminal
  • It now also is fully linear such that at least 0.5 percent of all arcs have to be a shortcutting terminal

TODO

  • Update unit tests
  • Fix commits are messed up in their content and comments

…t terminal

- It now only cares about the shortcutting terminal
- It now also is fully linear such that at least 0.5 percent of all arcs have to be
  a shortcutting terminal
@SSoelvsten SSoelvsten added ✨ optimisation It's all about speed / space 📁 internal This is where the ✨magic✨happens labels Apr 4, 2024
@SSoelvsten SSoelvsten self-assigned this Apr 4, 2024
@SSoelvsten SSoelvsten changed the title Simplify 'Terminal Count' heuristic to be linear and ignore idempotent terminal Internal/quantify/terminal heuristic 4 Apr 4, 2024
@SSoelvsten SSoelvsten changed the title Internal/quantify/terminal heuristic 4 Internal/quantify/terminal heuristic (4) Apr 4, 2024
@SSoelvsten SSoelvsten force-pushed the internal/quantify/terminal_heuristic__4 branch from 0888285 to 0ac54cb Compare April 4, 2024 12:18
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.267%. Comparing base (e3ab240) to head (0ac54cb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##              main      #648       +/-   ##
=============================================
- Coverage   97.315%   97.267%   -0.048%     
=============================================
  Files           90        90               
  Lines         6480      6477        -3     
=============================================
- Hits          6306      6300        -6     
- Misses         174       177        +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This comment was marked as off-topic.

Copy link

github-actions bot commented Apr 4, 2024

🟢 Regression Test (QBF 'breakthrough/3x4_19_bwnib')

'origin/internal/quantify/terminal_heuristic__4' is a change in performance of 0.25% (stdev: 0.22%).

... origin/main origin/internal/quantify/terminal_heuristic__4
Mean 24409.67 24348.67
Standard Deviation 54.88 38.40

Number of samples: 3

This comment was marked as off-topic.

Copy link

github-actions bot commented Apr 4, 2024

🔴 Regression Test (QBF 'domineering/5x5_13_bwnib')

'origin/internal/quantify/terminal_heuristic__4' is a change in performance of -13.37% (stdev: 0.49%).

... origin/main origin/internal/quantify/terminal_heuristic__4
Mean 22691.00 25724.00
Standard Deviation 99.00 126.63

Number of samples: 3

This comment was marked as off-topic.

Copy link

github-actions bot commented Apr 4, 2024

🔴 Regression Test (QBF 'breakthrough_dual/3x6_10_bwnib')

'origin/internal/quantify/terminal_heuristic__4' is a change in performance of -50.18% (stdev: 1.35%).

... origin/main origin/internal/quantify/terminal_heuristic__4
Mean 3532.00 5304.25
Standard Deviation 47.70 25.72

Number of samples: 4

Copy link

github-actions bot commented Apr 4, 2024

🟢 Regression Test (QBF 'httt/4x4_9_tippy_bwnib')

'origin/internal/quantify/terminal_heuristic__4' is a change in performance of 1.28% (stdev: 0.95%).

... origin/main origin/internal/quantify/terminal_heuristic__4
Mean 17546.00 17322.00
Standard Deviation 166.30 67.67

Number of samples: 3

Copy link

github-actions bot commented Apr 4, 2024

🟢 Regression Test (QBF 'hex/hein_08_5x5-11_bwnib')

'origin/internal/quantify/terminal_heuristic__4' is a change in performance of 1.09% (stdev: 1.21%).

... origin/main origin/internal/quantify/terminal_heuristic__4
Mean 41775.33 41318.00
Standard Deviation 505.82 144.94

Number of samples: 3

Copy link

github-actions bot commented Apr 4, 2024

🔴 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')

'origin/internal/quantify/terminal_heuristic__4' is a change in performance of -137.43% (stdev: 0.73%).

... origin/main origin/internal/quantify/terminal_heuristic__4
Mean 11345.25 26936.75
Standard Deviation 57.15 196.23

Number of samples: 4

Copy link

github-actions bot commented Apr 4, 2024

🟢 Regression Test (Picotrav 'adder')

'origin/internal/quantify/terminal_heuristic__4' is a change in performance of 0.54% (stdev: 0.62%).

... origin/main origin/internal/quantify/terminal_heuristic__4
Mean 9424.50 9373.75
Standard Deviation 58.03 20.69

Number of samples: 4

Copy link

github-actions bot commented Apr 4, 2024

🟢 Regression Test (QBF 'connect4/6x6_11_connect4_bwnib')

'origin/internal/quantify/terminal_heuristic__4' is a change in performance of 1.64% (stdev: 1.90%).

... origin/main origin/internal/quantify/terminal_heuristic__4
Mean 16877.00 16601.00
Standard Deviation 320.61 40.60

Number of samples: 4

Copy link

github-actions bot commented Apr 4, 2024

🔴 Regression Test (QBF 'ep_dual/8x8_6_e-8-1_p-2-3_bwnib')

'origin/internal/quantify/terminal_heuristic__4' is a change in performance of -18.21% (stdev: 4.85%).

... origin/main origin/internal/quantify/terminal_heuristic__4
Mean 4082.89 4826.22
Standard Deviation 197.95 150.86

Number of samples: 9

Copy link

github-actions bot commented Apr 4, 2024

🟡 Regression Test (14-Queens)

'origin/internal/quantify/terminal_heuristic__4' is a change in performance of -0.35% (stdev: 0.50%).

... origin/main origin/internal/quantify/terminal_heuristic__4
Mean 268011.67 268962.33
Standard Deviation 1156.10 1352.81

Number of samples: 3

@SSoelvsten SSoelvsten closed this Apr 4, 2024
@SSoelvsten SSoelvsten deleted the internal/quantify/terminal_heuristic__4 branch April 4, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📁 internal This is where the ✨magic✨happens ✨ optimisation It's all about speed / space
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant