Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bdd/diff op #667

Merged
merged 10 commits into from
May 30, 2024
Merged

Bdd/diff op #667

merged 10 commits into from
May 30, 2024

Conversation

SSoelvsten
Copy link
Owner

@SSoelvsten SSoelvsten commented May 30, 2024

Closes #664 by adding - and -= operator overloads. Now that we are at it anyways, let's add + and * as aliases for bdd_or and bdd_and too. And, we may as well do the same for ZDDs too.

@SSoelvsten SSoelvsten added ✨ feature New operation or other feature 📁 bdd Binary Decision Diagrams labels May 30, 2024
@SSoelvsten SSoelvsten added this to the v2.1 : Relational Product milestone May 30, 2024
@SSoelvsten SSoelvsten self-assigned this May 30, 2024
Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.576%. Comparing base (9e79baa) to head (35bad41).

Current head 35bad41 differs from pull request most recent head 59832cb

Please upload reports for the commit 59832cb to get more accurate results.

Additional details and impacted files
@@              Coverage Diff              @@
##              main      #667       +/-   ##
=============================================
+ Coverage   97.387%   97.576%   +0.189%     
=============================================
  Files           90        90               
  Lines         6544      6560       +16     
=============================================
+ Hits          6373      6401       +28     
+ Misses         171       159       -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 30, 2024

🟢 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')

'ssoelvsten/adiar/bdd/diff_op' is a change in performance of 0.09% (stdev: 0.57%).

... origin/main ssoelvsten/adiar/bdd/diff_op
Mean 29705.00 29677.90
Standard Deviation 153.47 168.41

Number of samples: 10

Copy link

github-actions bot commented May 30, 2024

🟢 Regression Test (QBF 'hex/hein_08_5x5-11_bwnib')

'ssoelvsten/adiar/bdd/diff_op' is a change in performance of 0.34% (stdev: 0.82%).

... origin/main ssoelvsten/adiar/bdd/diff_op
Mean 16831.50 16774.30
Standard Deviation 137.85 51.96

Number of samples: 10

Copy link

github-actions bot commented May 30, 2024

🟢 Regression Test (QBF 'ep_dual/8x8_6_e-8-1_p-2-3_bwnib')

'ssoelvsten/adiar/bdd/diff_op' is a change in performance of 0.79% (stdev: 1.21%).

... origin/main ssoelvsten/adiar/bdd/diff_op
Mean 5155.70 5114.90
Standard Deviation 62.36 34.74

Number of samples: 10

Copy link

github-actions bot commented May 30, 2024

🟡 Regression Test (QBF 'breakthrough_dual/3x6_10_bwnib')

'ssoelvsten/adiar/bdd/diff_op' is a change in performance of -0.14% (stdev: 0.77%).

... origin/main ssoelvsten/adiar/bdd/diff_op
Mean 5172.10 5179.10
Standard Deviation 25.31 40.04

Number of samples: 10

Copy link

github-actions bot commented May 30, 2024

🟡 Regression Test (Picotrav 'adder')

'ssoelvsten/adiar/bdd/diff_op' is a change in performance of -0.07% (stdev: 0.60%).

... origin/main ssoelvsten/adiar/bdd/diff_op
Mean 9558.20 9565.10
Standard Deviation 57.08 38.58

Number of samples: 10

Further cleans up src/adiar/bdd/bdd.cpp to make it more maintainable
Copy link

github-actions bot commented May 30, 2024

🟡 Regression Test (12-Queens)

'ssoelvsten/adiar/bdd/diff_op' is a change in performance of -0.16% (stdev: 0.40%).

... origin/main ssoelvsten/adiar/bdd/diff_op
Mean 11502.60 11521.40
Standard Deviation 45.98 44.41

Number of samples: 10

Copy link

github-actions bot commented May 30, 2024

🟢 Regression Test (QBF 'domineering/5x5_13_bwnib')

'ssoelvsten/adiar/bdd/diff_op' is a change in performance of 0.05% (stdev: 0.26%).

... origin/main ssoelvsten/adiar/bdd/diff_op
Mean 15460.60 15452.30
Standard Deviation 29.50 40.06

Number of samples: 10

Copy link

github-actions bot commented May 30, 2024

🟡 Regression Test (QBF 'connect4/6x6_11_connect4_bwnib')

'ssoelvsten/adiar/bdd/diff_op' is a change in performance of -0.17% (stdev: 0.54%).

... origin/main ssoelvsten/adiar/bdd/diff_op
Mean 12092.80 12113.40
Standard Deviation 64.92 38.69

Number of samples: 10

Copy link

github-actions bot commented May 30, 2024

🟡 Regression Test (QBF 'breakthrough/3x4_19_bwnib')

'ssoelvsten/adiar/bdd/diff_op' is a change in performance of -0.63% (stdev: 1.22%).

... origin/main ssoelvsten/adiar/bdd/diff_op
Mean 22206.20 22345.60
Standard Deviation 56.51 273.65

Number of samples: 10

Copy link

github-actions bot commented May 30, 2024

🟢 Regression Test (QBF 'httt/4x4_9_tippy_bwnib')

'ssoelvsten/adiar/bdd/diff_op' is a change in performance of 0.03% (stdev: 1.49%).

... origin/main ssoelvsten/adiar/bdd/diff_op
Mean 9406.80 9404.30
Standard Deviation 139.78 95.46

Number of samples: 10

Copy link

github-actions bot commented May 30, 2024

🟡 Regression Test (Picotrav 'mem_ctrl')

'ssoelvsten/adiar/bdd/diff_op' is a change in performance of -0.05% (stdev: 0.34%).

... origin/main ssoelvsten/adiar/bdd/diff_op
Mean 114327.60 114380.80
Standard Deviation 251.58 387.49

Number of samples: 5

Copy link

github-actions bot commented May 30, 2024

🟡 Regression Test (14-Queens)

'ssoelvsten/adiar/bdd/diff_op' is a change in performance of -0.55% (stdev: 0.99%).

... origin/main ssoelvsten/adiar/bdd/diff_op
Mean 271688.33 273177.33
Standard Deviation 266.50 2699.68

Number of samples: 3

Copy link

github-actions bot commented May 30, 2024

🟢 Regression Test (Picotrav 'arbiter')

'ssoelvsten/adiar/bdd/diff_op' is a change in performance of 5.44% (stdev: 16.98%).

... origin/main ssoelvsten/adiar/bdd/diff_op
Mean 68631.50 64895.80
Standard Deviation 11656.97 449.72

Number of samples: 10

@SSoelvsten SSoelvsten merged commit f2f0bf9 into main May 30, 2024
15 checks passed
@SSoelvsten SSoelvsten deleted the bdd/diff_op branch May 30, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📁 bdd Binary Decision Diagrams ✨ feature New operation or other feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add - and -= operator overload to adiar::bdd
1 participant