Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bdd_replace #670

Merged
merged 8 commits into from
Jun 7, 2024
Merged

Add bdd_replace #670

merged 8 commits into from
Jun 7, 2024

Conversation

SSoelvsten
Copy link
Owner

Implements the foundational core of #498 and closes #669 .

@SSoelvsten SSoelvsten added ✨ feature New operation or other feature 📁 bdd Binary Decision Diagrams labels Jun 6, 2024
@SSoelvsten SSoelvsten added this to the v2.1 : Relational Product milestone Jun 6, 2024
@SSoelvsten SSoelvsten self-assigned this Jun 6, 2024
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 96.66667% with 9 lines in your changes missing coverage. Please review.

Project coverage is 97.760%. Comparing base (f2f0bf9) to head (b131fd5).
Report is 1 commits behind head on main.

Current head b131fd5 differs from pull request most recent head d39bea8

Please upload reports for the commit d39bea8 to get more accurate results.

Files Patch % Lines
src/adiar/bdd/replace.cpp 75.000% 4 Missing ⚠️
src/adiar/statistics.cpp 94.118% 3 Missing ⚠️
src/adiar/internal/algorithms/reduce.h 95.455% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##              main      #670       +/-   ##
=============================================
- Coverage   97.793%   97.760%   -0.033%     
=============================================
  Files           90        92        +2     
  Lines         6614      6829      +215     
=============================================
+ Hits          6468      6676      +208     
- Misses         146       153        +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 6, 2024

🟡 Regression Test (12-Queens)

'ssoelvsten/adiar/bdd/replace' is a change in performance of -0.20% (stdev: 1.01%).

... origin/main ssoelvsten/adiar/bdd/replace
Mean 11683.50 11706.50
Standard Deviation 52.95 118.07

Number of samples: 6

Copy link

github-actions bot commented Jun 6, 2024

🟢 Regression Test (Picotrav 'adder')

'ssoelvsten/adiar/bdd/replace' is a change in performance of 0.41% (stdev: 9.16%).

... origin/main ssoelvsten/adiar/bdd/replace
Mean 9776.60 9736.50
Standard Deviation 848.48 891.50

Number of samples: 10

Copy link

github-actions bot commented Jun 6, 2024

🟡 Regression Test (QBF 'breakthrough/3x4_19_bwnib')

'ssoelvsten/adiar/bdd/replace' is a change in performance of -0.14% (stdev: 0.52%).

... origin/main ssoelvsten/adiar/bdd/replace
Mean 21919.80 21950.00
Standard Deviation 114.37 62.08

Number of samples: 5

Copy link

github-actions bot commented Jun 6, 2024

🟡 Regression Test (QBF 'connect4/6x6_11_connect4_bwnib')

'ssoelvsten/adiar/bdd/replace' is a change in performance of -1.41% (stdev: 2.21%).

... origin/main ssoelvsten/adiar/bdd/replace
Mean 12235.83 12408.00
Standard Deviation 116.43 274.21

Number of samples: 6

Copy link

github-actions bot commented Jun 6, 2024

🟢 Regression Test (Picotrav 'arbiter')

'ssoelvsten/adiar/bdd/replace' is a change in performance of 12.54% (stdev: 20.24%).

... origin/main ssoelvsten/adiar/bdd/replace
Mean 74110.10 64815.60
Standard Deviation 14999.54 380.32

Number of samples: 10

Copy link

github-actions bot commented Jun 6, 2024

🟡 Regression Test (QBF 'domineering/5x5_13_bwnib')

'ssoelvsten/adiar/bdd/replace' is a change in performance of -0.52% (stdev: 0.64%).

... origin/main ssoelvsten/adiar/bdd/replace
Mean 15227.67 15306.17
Standard Deviation 18.23 97.53

Number of samples: 6

Copy link

github-actions bot commented Jun 6, 2024

🟢 Regression Test (QBF 'breakthrough_dual/3x6_10_bwnib')

'ssoelvsten/adiar/bdd/replace' is a change in performance of 2.57% (stdev: 8.64%).

... origin/main ssoelvsten/adiar/bdd/replace
Mean 5435.40 5295.60
Standard Deviation 469.54 378.30

Number of samples: 10

Copy link

github-actions bot commented Jun 6, 2024

🟢 Regression Test (QBF 'ep_dual/8x8_6_e-8-1_p-2-3_bwnib')

'ssoelvsten/adiar/bdd/replace' is a change in performance of 0.08% (stdev: 0.57%).

... origin/main ssoelvsten/adiar/bdd/replace
Mean 5049.33 5045.50
Standard Deviation 28.70 24.40

Number of samples: 6

Copy link

github-actions bot commented Jun 6, 2024

🟡 Regression Test (QBF 'hex/hein_08_5x5-11_bwnib')

'ssoelvsten/adiar/bdd/replace' is a change in performance of -0.68% (stdev: 1.13%).

... origin/main ssoelvsten/adiar/bdd/replace
Mean 17118.60 17235.60
Standard Deviation 34.50 195.13

Number of samples: 5

Copy link

github-actions bot commented Jun 6, 2024

🟢 Regression Test (QBF 'httt/4x4_9_tippy_bwnib')

'ssoelvsten/adiar/bdd/replace' is a change in performance of 1.37% (stdev: 2.10%).

... origin/main ssoelvsten/adiar/bdd/replace
Mean 9482.17 9352.17
Standard Deviation 199.60 50.62

Number of samples: 6

Copy link

github-actions bot commented Jun 6, 2024

🟢 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')

'ssoelvsten/adiar/bdd/replace' is a change in performance of 0.63% (stdev: 2.15%).

... origin/main ssoelvsten/adiar/bdd/replace
Mean 29973.80 29786.40
Standard Deviation 643.26 385.23

Number of samples: 5

Copy link

github-actions bot commented Jun 6, 2024

🟡 Regression Test (Picotrav 'mem_ctrl')

'ssoelvsten/adiar/bdd/replace' is a change in performance of -0.11% (stdev: 0.33%).

... origin/main ssoelvsten/adiar/bdd/replace
Mean 115058.00 115185.00
Standard Deviation 382.41 371.15

Number of samples: 3

Copy link

github-actions bot commented Jun 6, 2024

🟡 Regression Test (14-Queens)

'ssoelvsten/adiar/bdd/replace' is a change in performance of -0.12% (stdev: 0.35%).

... origin/main ssoelvsten/adiar/bdd/replace
Mean 268672.00 269000.00
Standard Deviation 946.63 339.75

Number of samples: 3

@SSoelvsten SSoelvsten merged commit e82ec26 into main Jun 7, 2024
14 checks passed
@SSoelvsten SSoelvsten deleted the bdd/replace branch June 12, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📁 bdd Binary Decision Diagrams ✨ feature New operation or other feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add bdd_replace statistics
1 participant