-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BDD/RelProd/Quantification Pruning #673
Conversation
The most vital conditional is still left as a TODO since it requires a single loop unrolling
🟡 Regression Test (QBF 'breakthrough_dual/3x6_10_bwnib')'ssoelvsten/adiar/bdd/relprod/prune' is a change in performance of -1.40% (stdev: 1.28%).
Number of samples: 3 |
🔴 Regression Test (QBF 'hex/hein_08_5x5-11_bwnib')'ssoelvsten/adiar/bdd/relprod/prune' is a change in performance of -0.66% (stdev: 0.26%).
Number of samples: 3 |
🔴 Regression Test (QBF 'breakthrough/3x4_19_bwnib')'ssoelvsten/adiar/bdd/relprod/prune' is a change in performance of -1.33% (stdev: 0.26%).
Number of samples: 3 |
🟢 Regression Test (QBF 'httt/4x4_9_tippy_bwnib')'ssoelvsten/adiar/bdd/relprod/prune' is a change in performance of 0.89% (stdev: 4.20%).
Number of samples: 3 |
🟡 Regression Test (QBF 'domineering/5x5_13_bwnib')'ssoelvsten/adiar/bdd/relprod/prune' is a change in performance of -0.92% (stdev: 0.87%).
Number of samples: 3 |
🟡 Regression Test (QBF 'connect4/6x6_11_connect4_bwnib')'ssoelvsten/adiar/bdd/relprod/prune' is a change in performance of -1.78% (stdev: 2.00%).
Number of samples: 3 |
🟡 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')'ssoelvsten/adiar/bdd/relprod/prune' is a change in performance of -0.88% (stdev: 0.56%).
Number of samples: 3 |
🟢 Regression Test (QBF 'ep_dual/8x8_6_e-8-1_p-2-3_bwnib')'ssoelvsten/adiar/bdd/relprod/prune' is a change in performance of 0.45% (stdev: 2.34%).
Number of samples: 4 |
🟢 Regression Test (12-Queens)'ssoelvsten/adiar/bdd/relprod/prune' is a change in performance of 1.58% (stdev: 0.41%).
Number of samples: 4 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #673 +/- ##
=============================================
+ Coverage 97.846% 97.862% +0.016%
=============================================
Files 93 93
Lines 6917 6970 +53
=============================================
+ Hits 6768 6821 +53
Misses 149 149 ☔ View full report in Codecov by Sentry. |
🟢 Regression Test (14-Queens)'ssoelvsten/adiar/bdd/relprod/prune' is a change in performance of 2.84% (stdev: 0.11%).
Number of samples: 3 |
🟢 Regression Test (Picotrav 'adder')'ssoelvsten/adiar/bdd/relprod/prune' is a change in performance of 5.92% (stdev: 11.51%).
Number of samples: 10 |
🟡 Regression Test (Picotrav 'arbiter')'ssoelvsten/adiar/bdd/relprod/prune' is a change in performance of -4.77% (stdev: 19.51%).
Number of samples: 9 |
🟡 Regression Test (Picotrav 'mem_ctrl')'ssoelvsten/adiar/bdd/relprod/prune' is a change in performance of -1.34% (stdev: 5.37%).
Number of samples: 8 |
Optimisation from #502 : Integrates the pruning optimisation directly within the
bdd_and
transposition sweep.