Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional/single output iterator #695

Merged
merged 4 commits into from
Oct 23, 2024
Merged

Conversation

SSoelvsten
Copy link
Owner

Closes #691 .

Doing it like this follows the STL library. The previous versions
of these functions are still available but are deprecated.
@SSoelvsten SSoelvsten added ✨ feature New operation or other feature ❕ deprecation Some day, something will be superseeded ✨ code quality Uncle Bob would be proud labels Oct 23, 2024
@SSoelvsten SSoelvsten added this to the v2.0 : API Revamp milestone Oct 23, 2024
@SSoelvsten SSoelvsten self-assigned this Oct 23, 2024
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.052%. Comparing base (ae4cc77) to head (81f6dca).
Report is 4 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##              main      #695       +/-   ##
=============================================
+ Coverage   98.049%   98.052%   +0.002%     
=============================================
  Files           93        93               
  Lines         7126      7134        +8     
=============================================
+ Hits          6987      6995        +8     
  Misses         139       139               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

🟡 Regression Test (12-Queens)

'ssoelvsten/adiar/functional/single_output_iterator' is a change in performance of 0.22% (stdev: 1.28%).

... origin/main ssoelvsten/adiar/functional/single_output_iterator
Mean 11533.67 11508.33
Standard Deviation 147.17 85.03

Number of samples: 3

Copy link

🟡 Regression Test (Picotrav 'adder')

'ssoelvsten/adiar/functional/single_output_iterator' is a change in performance of -0.81% (stdev: 0.52%).

... origin/main ssoelvsten/adiar/functional/single_output_iterator
Mean 9828.00 9908.00
Standard Deviation 45.21 51.97

Number of samples: 3

Copy link

🟡 Regression Test (QBF 'breakthrough_dual/3x6_10_bwnib')

'ssoelvsten/adiar/functional/single_output_iterator' is a change in performance of 0.43% (stdev: 0.98%).

... origin/main ssoelvsten/adiar/functional/single_output_iterator
Mean 5139.67 5117.67
Standard Deviation 50.54 24.79

Number of samples: 3

Copy link

🟡 Regression Test (QBF 'breakthrough/3x4_19_bwnib')

'ssoelvsten/adiar/functional/single_output_iterator' is a change in performance of -0.22% (stdev: 1.52%).

... origin/main ssoelvsten/adiar/functional/single_output_iterator
Mean 21864.33 21913.00
Standard Deviation 331.41 96.50

Number of samples: 3

Copy link

🟡 Regression Test (Picotrav 'arbiter')

'ssoelvsten/adiar/functional/single_output_iterator' is a change in performance of 0.24% (stdev: 0.74%).

... origin/main ssoelvsten/adiar/functional/single_output_iterator
Mean 64207.67 64051.00
Standard Deviation 68.22 473.74

Number of samples: 3

Copy link

🟡 Regression Test (QBF 'connect4/6x6_11_connect4_bwnib')

'ssoelvsten/adiar/functional/single_output_iterator' is a change in performance of -0.42% (stdev: 0.76%).

... origin/main ssoelvsten/adiar/functional/single_output_iterator
Mean 12013.67 12064.33
Standard Deviation 22.59 91.74

Number of samples: 3

Copy link

🟡 Regression Test (QBF 'domineering/5x5_13_bwnib')

'ssoelvsten/adiar/functional/single_output_iterator' is a change in performance of 1.06% (stdev: 1.47%).

... origin/main ssoelvsten/adiar/functional/single_output_iterator
Mean 15347.67 15185.67
Standard Deviation 225.11 5.51

Number of samples: 3

Copy link

🟡 Regression Test (QBF 'ep_dual/8x8_6_e-8-1_p-2-3_bwnib')

'ssoelvsten/adiar/functional/single_output_iterator' is a change in performance of 0.34% (stdev: 0.26%).

... origin/main ssoelvsten/adiar/functional/single_output_iterator
Mean 5047.67 5030.33
Standard Deviation 12.90 10.60

Number of samples: 3

Copy link

🟡 Regression Test (QBF 'httt/4x4_9_tippy_bwnib')

'ssoelvsten/adiar/functional/single_output_iterator' is a change in performance of 0.80% (stdev: 0.93%).

... origin/main ssoelvsten/adiar/functional/single_output_iterator
Mean 9381.00 9306.33
Standard Deviation 87.71 56.07

Number of samples: 3

Copy link

🟡 Regression Test (QBF 'hex/hein_08_5x5-11_bwnib')

'ssoelvsten/adiar/functional/single_output_iterator' is a change in performance of -0.51% (stdev: 0.60%).

... origin/main ssoelvsten/adiar/functional/single_output_iterator
Mean 16634.33 16718.67
Standard Deviation 80.70 100.03

Number of samples: 3

Copy link

🟡 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')

'ssoelvsten/adiar/functional/single_output_iterator' is a change in performance of -0.50% (stdev: 1.24%).

... origin/main ssoelvsten/adiar/functional/single_output_iterator
Mean 29756.67 29904.67
Standard Deviation 120.43 369.46

Number of samples: 3

Copy link

🟡 Regression Test (Picotrav 'mem_ctrl')

'ssoelvsten/adiar/functional/single_output_iterator' is a change in performance of -0.16% (stdev: 0.70%).

... origin/main ssoelvsten/adiar/functional/single_output_iterator
Mean 115647.33 115837.00
Standard Deviation 212.60 813.34

Number of samples: 3

Copy link

🟡 Regression Test (14-Queens)

'ssoelvsten/adiar/functional/single_output_iterator' is a change in performance of 0.04% (stdev: 0.51%).

... origin/main ssoelvsten/adiar/functional/single_output_iterator
Mean 265195.33 265088.33
Standard Deviation 1363.31 1166.19

Number of samples: 3

@SSoelvsten SSoelvsten merged commit 4944934 into main Oct 23, 2024
56 of 57 checks passed
@SSoelvsten SSoelvsten deleted the functional/single_output_iterator branch October 23, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ code quality Uncle Bob would be proud ❕ deprecation Some day, something will be superseeded ✨ feature New operation or other feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output Iterators should be provided as only begin and no end
1 participant