Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapting hpx::find and friends to C++20 #4885

Merged
merged 1 commit into from
Aug 13, 2020
Merged

Adapting hpx::find and friends to C++20 #4885

merged 1 commit into from
Aug 13, 2020

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented Aug 6, 2020 •
edited
Loading

This adds compatibility to C++20 for

  • find find_if find_if_not
  • find_end find_first_of

This also adds range based overloads for those algorithms

  • find find_if find_if_not
  • find_end find_first_of

This also adds constexpr to a couple of facilities (as a flyby).

This was referenced Aug 8, 2020
Closed
Closed
Closed
@hkaiser hkaiser force-pushed the find_cpos branch 9 times, most recently from 8c8fd35 to 44dc675 Compare August 12, 2020 18:30
@hkaiser hkaiser marked this pull request as ready for review August 12, 2020 18:31
@hkaiser
Copy link
Member Author

hkaiser commented Aug 12, 2020

This is ready for review now.

@hkaiser hkaiser added this to the 1.5.0 milestone Aug 12, 2020
msimberg
msimberg previously approved these changes Aug 13, 2020
View reviewed changes
Copy link
Contributor

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hkaiser hkaiser merged commit adc6d46 into master Aug 13, 2020
@hkaiser hkaiser deleted the find_cpos branch August 13, 2020 15:45
@hkaiser hkaiser mentioned this pull request Jul 9, 2021
Closed
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msimberg msimberg msimberg left review comments

@aurianer aurianer Awaiting requested review from aurianer

@biddisco biddisco Awaiting requested review from biddisco

Assignees
No one assigned
Labels
category: algorithms type: compatibility issue type: enhancement
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@hkaiser @msimberg