Adding parallel make_heap #4964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkaiser
requested review from
aurianer,
biddisco and
msimberg
as code owners
This was referenced Sep 15, 2020
|
Very cool to see this being revisited! |
msimberg
requested changes
Sep 17, 2020
libs/parallelism/algorithms/include/hpx/parallel/algorithms/make_heap.hpp
Outdated
Show resolved
Hide resolved
|
Hmm, this is maybe not rebased on master? I think the CircleCI failure is just because of that. The jenkins builders build a merge with master. |
I rebased this again, let's see. |
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This revives #1914, which has never made it in. This also converts the algorithm to CPOs and makes it conforming to C++20. Thanks again @Syntaf for working on this and sorry it took so long to get back to it.