Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add P0443r14 executor and a a few P1897 algorithms #5053

Merged
merged 38 commits into from
Feb 26, 2021
Merged

Add P0443r14 executor and a a few P1897 algorithms #5053

merged 38 commits into from
Feb 26, 2021

Conversation

msimberg
Copy link
Contributor

@msimberg msimberg commented Nov 13, 2020 •
edited
Loading

Adds the remaining CPOs and traits from P0443r14 (see #5045). I've used the fallback implementations from P0443r14 pretty much verbatim, so there might be room for changes here.

Also adds transform and sync_wait as the first algorithms (and wait, get for symmetry with the current future functionality, although these should proably not stay). Also adds a sink_receiver (should be called void_receiver?).

Adds a simple executor for our coroutines based on the new functionality. The bulk_execute functionality is incomplete but I'd like to keep it like this for now until the proposal evolves a bit more.

Extends tag_fallback_invoke with tag_priority_invoke, which gives three options: tag_override_invoke which always takes precedence over user-defined tag_invokes, then uses user-defined tag_invokes, and finally uses tag_fallback_invoke if nothing else matches.

@K-ballo (and others interested), I had a need for a type list transform and unique. I'm sure you have a better idea of how to do that efficiently (especially unique), so I'd appreciate your eyes on that (see https://github.com/msimberg/hpx/blob/1fa6ec165d410d0508183cb0e1d532e1840f0cf6/libs/core/type_support/include/hpx/type_support/pack.hpp#L196-L237).

Includes #5033.

To do:

  • Add documentation for the new CPOs
  • Update documentation for the existing CPOs
  • Move traits out from traits namespace (objections?)

@msimberg msimberg added this to the 1.6.0 milestone Nov 13, 2020
@msimberg
Copy link
Contributor Author

retest

@msimberg msimberg marked this pull request as ready for review November 25, 2020 12:00
@msimberg msimberg force-pushed the p0443-executor branch 2 times, most recently from 68648e6 to 638d57b Compare December 16, 2020 08:38
@msimberg msimberg force-pushed the p0443-executor branch 2 times, most recently from c7eee30 to c38672c Compare January 6, 2021 12:33
@msimberg msimberg modified the milestones: 1.6.0, 1.7.0 Jan 11, 2021
@msimberg msimberg force-pushed the p0443-executor branch 2 times, most recently from 9b1de25 to d7d32af Compare January 20, 2021 15:15
@msimberg
Add simple P0443 executor implementation
29d0208
@msimberg
Add tag_priority{,_noexcept} helper structs
ad16d32 
tag_priority{,_noexcept} extends the tag_fallback{,_noexcept} helper
structs to also allow overriding user-defined tag_invoke overloads.
tag_priority{,_noexcept} will prefer tag_override_invoke overloads if
available, then tag_invoke overloads if available, and last
tag_fallback_invoke overloads if available. This helper struct is useful
for implementing P0443 customization points which prefer member
functions whenever available, even if tag_invoke overloads are
available. On the other hand they fall back in many cases to default
implementations based on other customization points.
@msimberg
Update sender, receiver, operation_state CPOs to use tag_priority
3c69ae3
@msimberg
Add missing CPOs and missing fallback overloads for P0443
ce16217
@msimberg
Add first implementations of P0443 wait, get, then, and a dummy sink …
f478dd4 
…receiver
@msimberg
Update basic host P0443 executor to conform to scheduler and sender c…
acaebb1 
…oncepts
@msimberg
Rename basic P0443 algorithms to better match proposed names
9dcb0f9
@msimberg
Copy link
Contributor Author

I welcome reviews on this one.

hkaiser
hkaiser previously approved these changes Feb 24, 2021
View reviewed changes
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@msimberg
Copy link
Contributor Author

msimberg commented Feb 24, 2021 •
edited
Loading

LGTM, thanks!

Thanks @hkaiser for looking through this! I'm turning this back into a draft because it looks like gcc 7 and 8 are not happy with the changes. I'm not planning on making any further functional changes.

@msimberg msimberg marked this pull request as draft February 24, 2021 08:53
@hkaiser
Copy link
Member

hkaiser commented Feb 24, 2021

One question I had was whether we should use tag_fallback_invoke instead of tag_invoke where possible (based on our experience with segregating the segmented algorithms).

@msimberg
Copy link
Contributor Author

One question I had was whether we should use tag_fallback_invoke instead of tag_invoke where possible (based on our experience with segregating the segmented algorithms).

Absolutely! The P0443 customization points use tag_priority which gives both tag_fallback_invoke and tag_priority_invoke (the latter because according to P0443 member functions should always take precedence over free functions, or tag_invoke overloads in our case). sync_wait and transform are not even CPOs here, but should be, and should use tag_fallback_invoke (I've already changed this in upcoming commits).

@msimberg msimberg marked this pull request as ready for review February 25, 2021 16:55
@msimberg
Copy link
Contributor Author

This should now be ok. Let's see if CI agrees. GCC 7 and 8 seemed to be more eager in instantiating templates compared to newer versions of GCC and clang.

@msimberg msimberg force-pushed the p0443-executor branch 2 times, most recently from 44a0a10 to 2352d97 Compare February 26, 2021 08:46
@msimberg
Add more SFINAE to P0443 customization points
1862150 
- Move enable_ifs to template parameters
- Add enable_ifs to some member functions that did not have it
- Use enable_if_t instead of enable_if
- Change some leftover decay to decay_t
- Small fixes to basic_submit test
@msimberg msimberg changed the title P0443 executor Add P0443r14 executor and a a few P1897 algorithms Feb 26, 2021
@msimberg msimberg merged commit d027517 into STEllAR-GROUP:master Feb 26, 2021
@msimberg msimberg deleted the p0443-executor branch February 26, 2021 13:52
This was referenced Mar 8, 2021
Closed
Open
@aurianer aurianer added the category: senders/receivers Implementations of the p0443r14 / p2300 + p1897 proposals label May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkaiser hkaiser hkaiser left review comments

@sithhell sithhell Awaiting requested review from sithhell

@aurianer aurianer Awaiting requested review from aurianer

@K-ballo K-ballo Awaiting requested review from K-ballo

@biddisco biddisco Awaiting requested review from biddisco

Assignees
No one assigned
Labels
category: executors category: senders/receivers Implementations of the p0443r14 / p2300 + p1897 proposals type: enhancement
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@msimberg @hkaiser @aurianer