-
-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt transform_inclusive_scan to C++ 20 #5444
Merged
hkaiser
merged 5 commits into
STEllAR-GROUP:master
from
Jedi18:adapt_transform_inclusive_scan
Jul 30, 2021
Merged
Adapt transform_inclusive_scan to C++ 20 #5444
hkaiser
merged 5 commits into
STEllAR-GROUP:master
from
Jedi18:adapt_transform_inclusive_scan
Jul 30, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jedi18
requested review from
aurianer,
biddisco,
hkaiser and
msimberg
as code owners
July 13, 2021 07:40
This was referenced Jul 13, 2021
Jedi18
force-pushed
the
adapt_transform_inclusive_scan
branch
from
July 19, 2021 16:22
97a563c
to
7de5e43
Compare
hkaiser
reviewed
Jul 22, 2021
libs/parallelism/algorithms/include/hpx/parallel/algorithms/transform_inclusive_scan.hpp
Outdated
Show resolved
Hide resolved
hkaiser
reviewed
Jul 22, 2021
libs/parallelism/algorithms/include/hpx/parallel/algorithms/transform_inclusive_scan.hpp
Outdated
Show resolved
Hide resolved
hkaiser
reviewed
Jul 22, 2021
libs/parallelism/algorithms/include/hpx/parallel/algorithms/transform_inclusive_scan.hpp
Outdated
Show resolved
Hide resolved
hkaiser
reviewed
Jul 22, 2021
...arallelism/algorithms/include/hpx/parallel/container_algorithms/transform_inclusive_scan.hpp
Outdated
Show resolved
Hide resolved
hkaiser
reviewed
Jul 22, 2021
...arallelism/algorithms/include/hpx/parallel/container_algorithms/transform_inclusive_scan.hpp
Outdated
Show resolved
Hide resolved
Jedi18
force-pushed
the
adapt_transform_inclusive_scan
branch
3 times, most recently
from
July 26, 2021 03:52
4518a83
to
53d00bc
Compare
Can one of the admins verify this patch? |
hkaiser
reviewed
Jul 26, 2021
libs/parallelism/algorithms/include/hpx/parallel/algorithms/transform_inclusive_scan.hpp
Show resolved
Hide resolved
hkaiser
previously approved these changes
Jul 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Jedi18
force-pushed
the
adapt_transform_inclusive_scan
branch
from
July 30, 2021 04:36
53d00bc
to
2112dc4
Compare
Merge order - exlcusive_scan -> transform_exclusive_scan -> tranform_inclusive_scan |
… for transform_inclusive_scan
Jedi18
force-pushed
the
adapt_transform_inclusive_scan
branch
from
July 30, 2021 14:02
2112dc4
to
b86150d
Compare
msimberg
pushed a commit
that referenced
this pull request
Aug 6, 2021
Adapt transform_inclusive_scan to C++ 20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapted transform_inclusive_scan to C++ 20 and added container overloads. (range and sentinel). Added container tests. Seperated segmented overloads.
Any background context you want to provide?
Issue #4822
Issue #3646
Issue #1668
Issue #5156