-
-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add partial_sort_copy and adapt partial sort to c++ 20 #5630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jedi18
requested review from
aurianer,
biddisco,
hkaiser and
msimberg
as code owners
November 2, 2021 06:31
Jedi18
force-pushed
the
add_partial_sort
branch
from
November 2, 2021 07:19
72f8691
to
71e79ff
Compare
Performance test reportHPX PerformanceComparison
Info
Comparison
Info
Explanation of Symbols
|
Jedi18
force-pushed
the
add_partial_sort
branch
from
November 2, 2021 11:04
71e79ff
to
416e072
Compare
msimberg
added
category: algorithms
split: docs
PR targets documentation
split: local
PR targets local functionality
labels
Nov 3, 2021
@hkaiser Thanks for fixing the error! |
Performance test reportHPX PerformanceComparison
Info
Comparison
Info
Explanation of Symbols
|
hkaiser
approved these changes
Nov 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This was referenced Nov 6, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category: algorithms
split: docs
PR targets documentation
split: local
PR targets local functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @fjtapia for his partial_sort_copy implementation.
Added tag_fallback_invoke overloads for parallel and container overloads, normal and range tests for partial_sort and partial_sort_copy.
Any background context you want to provide?
Issue #4822
Issue #3646
Issue #1668