-
-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for data-parallelism for find algorithms #5650
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srinivasyadav18
requested review from
aurianer,
biddisco,
hkaiser and
msimberg
as code owners
November 14, 2021 13:27
36 tasks
hkaiser
changed the title
Adapt Simd find
Support for data-parallelism for find algorithms
Nov 15, 2021
Splits into header and source Replaces std::size_t with int for Vc datapar compatibility
…tible Enables forward iterator unit tests
srinivasyadav18
force-pushed
the
simd_find
branch
2 times, most recently
from
November 30, 2021 10:50
28bfe77
to
bec2871
Compare
Performance test reportHPX PerformanceComparison
Info
Comparison
Info
Explanation of Symbols
|
hkaiser
reviewed
Nov 30, 2021
util::loop_idx_n<ExPolicy>(base_idx, it, part_size, tok, | ||
[=, &tok, &op, &proj1, &proj2](auto t, std::size_t i) -> void { | ||
if (hpx::util::invoke(op, hpx::util::invoke(proj1, t), | ||
hpx::util::invoke(proj2, *first2))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use HPX_INVOKE()
instead of hpx::util::invoke()
in implementation files (not tests, etc.)
hkaiser
reviewed
Nov 30, 2021
libs/core/algorithms/include/hpx/parallel/algorithms/detail/find.hpp
Outdated
Show resolved
Hide resolved
hkaiser
reviewed
Nov 30, 2021
hkaiser
reviewed
Nov 30, 2021
hkaiser
reviewed
Nov 30, 2021
hkaiser
reviewed
Nov 30, 2021
hkaiser
reviewed
Nov 30, 2021
hkaiser
reviewed
Nov 30, 2021
@hkaiser Thanks for the review :), I will make the required changes soon. |
Co-authored-by: Hartmut Kaiser <hartmut.kaiser@gmail.com>
msimberg
reviewed
Dec 2, 2021
libs/core/algorithms/include/hpx/parallel/algorithms/detail/find.hpp
Outdated
Show resolved
Hide resolved
Replace hpx::util::invoke with HPX_INVOKE Replace std::forward with HPX_FORWARD
This is superseded by STEllAR-GROUP/hpx-local#21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category: algorithms
split: local
PR targets local functionality
type: compatibility issue
type: enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to fixing #2333
This implements vectorization support for
find
, find_end, find_first_of
,find_if
, andfind_if_not
Proposed Changes
find_first_of
andfind_end
.find
unit test into header and source.datapar find