docs: fix & improve parallel algorithms documentation 2 #5939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhumitattarde
requested review from
aurianer,
biddisco,
hkaiser and
msimberg
as code owners
hkaiser
reviewed
Jul 5, 2022
| /// The \a count algorithm returns the number of elements | ||
| /// satisfying the given criteria. | ||
| /// | ||
| template <typename InIter, typename T> | ||
| typename util::detail::algorithm_result<ExPolicy, |
There was a problem hiding this comment.
Synchronous algorithms (the ones not taking an execution policy) never return the algorithm_result_t<> helper type, but always the actual return type (here typename std::iterator_traits<InIter>::difference_type).
There was a problem hiding this comment.
Yes, missed this somehow. Check now?
hkaiser
reviewed
Jul 5, 2022
| /// satisfying the given criteria. | ||
| /// | ||
| template <typename InIter, typename F> | ||
| typename std::iterator_traits<InIter>::difference_type>::type |
There was a problem hiding this comment.
Suggested change
| typename std::iterator_traits<InIter>::difference_type>::type | |
| typename std::iterator_traits<InIter>::difference_type |
hkaiser
reviewed
Jul 5, 2022
| @@ -276,7 +276,7 @@ namespace hpx { | |||
| /// \a inclusive_scan may be non-deterministic. | |||
| /// | |||
| template <typename ExPolicy, typename FwdIter1, typename FwdIter2, | |||
| typename T, typename Op> | |||
| typename Op, typename T> | |||
There was a problem hiding this comment.
What's the rationale for this change?
There was a problem hiding this comment.
Here, Op is the fourth template parameter and T is fifth. Am I missing something?
|
bors merge |
Merged
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.