Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rename itr to correct type (reduce) #5954

Merged
merged 1 commit into from
Jul 15, 2022
Merged

refactor: rename itr to correct type (reduce) #5954

merged 1 commit into from
Jul 15, 2022

Conversation

bhumitattarde
Copy link
Contributor

Proposed Changes

  • renamed iterator to correct type (FwdIter to InItr) in some reduce overloads

hkaiser
hkaiser approved these changes Jul 15, 2022
View reviewed changes
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hkaiser hkaiser added this to the 1.8.1 milestone Jul 15, 2022
@hkaiser
Copy link
Member

hkaiser commented Jul 15, 2022

The inspect problem is fixed on master

@hkaiser
Copy link
Member

hkaiser commented Jul 15, 2022

bors merge

@bors
Copy link

bors bot commented Jul 15, 2022

Build succeeded:

@bors bors bot merged commit 3febca3 into STEllAR-GROUP:master Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkaiser hkaiser hkaiser approved these changes

@aurianer aurianer Awaiting requested review from aurianer

@biddisco biddisco Awaiting requested review from biddisco

@msimberg msimberg Awaiting requested review from msimberg

Assignees
No one assigned
Labels
type: compatibility issue type: enhancement
Projects
None yet
Milestone
1.8.1
Development

Successfully merging this pull request may close these issues.
2 participants
@bhumitattarde @hkaiser