-
-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrating sync_wait & sync_wait_with_variant #6015
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcq9102
requested review from
aurianer,
msimberg,
biddisco and
hkaiser
as code owners
September 18, 2022 17:07
hcq9102
force-pushed
the
integration_sync_wait
branch
from
September 19, 2022 22:13
392b1eb
to
705c413
Compare
Performance test reportHPX PerformanceComparison
Info
Comparison
Info
Comparison
Info
Explanation of Symbols
|
hcq9102
force-pushed
the
integration_sync_wait
branch
4 times, most recently
from
September 21, 2022 16:14
b21de9b
to
bbdabfe
Compare
hkaiser
added
type: enhancement
type: compatibility issue
category: senders/receivers
Implementations of the p0443r14 / p2300 + p1897 proposals
labels
Sep 21, 2022
hkaiser
changed the title
Integarting sync_wait & with_variant
Integrating sync_wait & sync_wait_with_variant
Sep 21, 2022
hkaiser
force-pushed
the
integration_sync_wait
branch
from
September 30, 2022 17:45
91d0068
to
ccf0650
Compare
@hcq9102 this should be fine now. Please note that I have also rebased (and force-pushed) this PR onto master. |
- flyby: fix tests
hkaiser
force-pushed
the
integration_sync_wait
branch
from
September 30, 2022 17:48
ccf0650
to
f9cf617
Compare
hkaiser
approved these changes
Oct 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
bors merge |
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category: senders/receivers
Implementations of the p0443r14 / p2300 + p1897 proposals
type: compatibility issue
type: enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes:
Ref: P2300R5
Integrate sync_wait and sync_wait_with_variant.
Checklist