Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating sync_wait & sync_wait_with_variant #6015

Merged
merged 5 commits into from
Oct 5, 2022

Conversation

hcq9102
Copy link
Contributor

@hcq9102 hcq9102 commented Sep 18, 2022

Proposed Changes:

Ref: P2300R5
Integrate sync_wait and sync_wait_with_variant.

Checklist

  • I have added a new feature and have added tests to go along with it.

@StellarBot
Copy link

Performance test report

HPX Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)(=)(=)

Info

PropertyBeforeAfter
HPX Datetime2022-05-31T12:57:29+00:002022-09-19T22:13:18+00:00
HPX Commitd5655f89fff673
Clusternamedaintdaint
Compiler/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Envfile
Hostnamenid01193nid00876
Datetime2022-05-31T15:13:01.357969+02:002022-09-20T00:27:10.756628+02:00

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch(=)

Info

PropertyBeforeAfter
HPX Datetime2022-05-31T12:57:29+00:002022-09-19T22:13:18+00:00
HPX Commitd5655f89fff673
Clusternamedaintdaint
Compiler/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Envfile
Hostnamenid01193nid00876
Datetime2022-05-31T15:13:18.026239+02:002022-09-20T00:27:27.376396+02:00

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add(=)--
Stream Benchmark - Scale(=)(=)(=)
Stream Benchmark - Triad(=)(=)-
Stream Benchmark - Copy(=)=(=)

Info

PropertyBeforeAfter
HPX Datetime2021-11-10T19:14:21+00:002022-09-19T22:13:18+00:00
HPX Commit71d8dbe9fff673
Clusternamedaintdaint
Compiler/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Envfile
Hostnamenid00120nid00876
Datetime2021-11-10T20:28:18.266961+01:002022-09-20T00:27:42.743177+02:00

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@hcq9102 hcq9102 force-pushed the integration_sync_wait branch 4 times, most recently from b21de9b to bbdabfe Compare September 21, 2022 16:14
@hkaiser hkaiser added type: enhancement type: compatibility issue category: senders/receivers Implementations of the p0443r14 / p2300 + p1897 proposals labels Sep 21, 2022
@hkaiser hkaiser added this to the 1.9.0 milestone Sep 21, 2022
@hkaiser
Copy link
Member

hkaiser commented Sep 21, 2022

@hcq9102 do we still need to merge #5956 before merging this?

@hcq9102
Copy link
Contributor Author

hcq9102 commented Sep 21, 2022

@hcq9102 do we still need to merge #5956 before merging this?

I think we don't need #5956 anymore.
But I would like to close #5956 after this PR is merged.

@hkaiser hkaiser changed the title Integarting sync_wait & with_variant Integrating sync_wait & sync_wait_with_variant Sep 21, 2022
@hkaiser
Copy link
Member

hkaiser commented Sep 30, 2022

@hcq9102 this should be fine now. Please note that I have also rebased (and force-pushed) this PR onto master.

Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hkaiser
Copy link
Member

hkaiser commented Oct 5, 2022

bors merge

@bors
Copy link

bors bot commented Oct 5, 2022

Build succeeded:

  • Bors

@bors bors bot merged commit e6b72cd into STEllAR-GROUP:master Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: senders/receivers Implementations of the p0443r14 / p2300 + p1897 proposals type: compatibility issue type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants