Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Virtualization support (jsc#SLE-10325) #609

Merged
merged 2 commits into from
Jun 17, 2020
Merged

Virtualization support (jsc#SLE-10325) #609

merged 2 commits into from
Jun 17, 2020

Conversation

tbazant
Copy link
Collaborator

@tbazant tbazant commented Jun 11, 2020

Description

This update updates the virtualization support for VMhosts and VMguests.

Checklist

  • Check all items that apply.

Are backports required?

  • To maintenance/SLE15SP1
  • To maintenance/SLE15SP0
  • To maintenance/SLE12SP5
  • To maintenance/SLE12SP4
  • To maintenance/SLE12SP3

@tbazant tbazant requested review from jfehlig and lproven June 11, 2020 11:14
@tbazant tbazant self-assigned this Jun 11, 2020
lproven
lproven suggested changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@lproven lproven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one small comment.

I was going to suggest moving "included in kernel" to the heading and list the supported products under it, but that would make the list inconsistent with the following lists.

Therefore I leave it up to you.

xml/virt_support.xml Outdated Show resolved Hide resolved
jfehlig
jfehlig reviewed Jun 12, 2020
View reviewed changes
xml/virt_support.xml
<listitem>
<para>
Microsoft Windows 2016
SLED 15 SP1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the only SLED variant that is tech preview? No SLED 15 SP2 or SLED 12 SPX?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, i took what's here https://confluence.suse.com/display/Virtualization/Support+Constraints without much intervention....if you're sure something's missing there, tell me

jfehlig
jfehlig reviewed Jun 12, 2020
View reviewed changes
Copy link
Collaborator

@jfehlig jfehlig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good,thanks! As you say, I hope all the removed text makes it to the corresponding release notes for all the affected products.

@tbazant tbazant requested a review from jfehlig June 12, 2020 18:16
@tbazant tbazant merged commit 0b62611 into master Jun 17, 2020
@tbazant tbazant deleted the tbazant-vm_support-jsc#SLE-10325 branch June 17, 2020 12:26
tbazant added a commit that referenced this pull request Jun 17, 2020
@tbazant
Virtualization support (jsc#SLE-10325) (#609)
ae3a835
tbazant added a commit that referenced this pull request Jun 17, 2020
@tbazant
Virtualization support (jsc#SLE-10325) (#609)
a83ac4c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lproven lproven lproven requested changes

@jfehlig jfehlig Awaiting requested review from jfehlig

Assignees

@tbazant tbazant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tbazant @jfehlig @lproven