Refact callgraph #1558
Open
Refact callgraph #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 3, 2024 00:03
make PTACallGraph inherite CallGraph
jumormt
reviewed
Oct 3, 2024
| @@ -1319,7 +1318,7 @@ cJSON* SVFIRWriter::toJson(const SVFModule* module) | |||
| F(pagReadFromTxt); | |||
| F(moduleIdentifier); | |||
|
|
|||
| F(FunctionSet); | |||
| // F(CallGraphNodeSet); | |||
jumormt
reviewed
Oct 3, 2024
| @@ -1773,7 +1772,7 @@ void SVFIRReader::readJson(SVFModule* module) | |||
| #define F(field) JSON_READ_FIELD_FWD(obj, module, field) | |||
| F(pagReadFromTxt); | |||
| F(moduleIdentifier); | |||
| F(FunctionSet); | |||
| // F(CallGraphNodeSet); | |||
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1558 +/- ##
==========================================
- Coverage 62.88% 62.75% -0.13%
==========================================
Files 245 247 +2
Lines 25681 25753 +72
Branches 4505 4518 +13
==========================================
+ Hits 16149 16161 +12
- Misses 9532 9592 +60
|
added 2 commits
October 3, 2024 20:46
add callGraphNode field in SVFArgument
yuleisui
reviewed
Oct 3, 2024
| @@ -163,6 +164,27 @@ SVFIR* SVFIRBuilder::build() | |||
|
|
|||
| pag->setNodeNumAfterPAGBuild(pag->getTotalNodeNum()); | |||
|
|
|||
| CallGraph* cg = llvmModuleSet()->callgraph; | |||
There was a problem hiding this comment.
Move to callgraphbuilder.
Remove PTACallGraph and PTACallGraphEdge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create PTACallGraph
make PTACallGraph inherite CallGraph