Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom panel styling, more adaptive palette, shortcuts #937

Merged
merged 2 commits into from
Dec 24, 2023

Conversation

olekhshch
Copy link
Contributor

  • vertical scrollbar on the right of the bottom panel (BP) removed

  • changed coordinates of the colour picker windows so they appear fully on the screen (previously, those windows were overflowing the editor's container)
    image

  • the palette is more adaptive to the screenwidth (shrinking, showing less colours if doesn't fit) to prevent earlier scrollbar appearance

  • if necessary, the palette can be expanded (arrow button to the right), so the whole palette is available without scrolling the BP. The popup can be closed by clicking the same button or anywhere on the svgcanvas
    image

  • BP's scrollbar's styling is the same as the styling of other toolbars
    image

  • preventDefault was added to the selectAll shortcut to avoid selecting the whole editor content (as on screenshot) (usually this selection appears after clicking a button on any panel and selecting svg objects with ctrl+A after that)
    image

  • also, preventDefault was added to rotation shortcuts (crtl+arrowLeft) because some browsers (e.g. OperaGX) are using this shortcut for navigation through routing history.

P.S. My Prettier configurations added some linebreaks to the edited files, but the npm run lint didn't catch it as an error, please let me know if I still should undo it.

@jfhenon jfhenon merged commit d502525 into SVG-Edit:master Dec 24, 2023
4 of 5 checks passed
@jfhenon
Copy link
Collaborator

jfhenon commented Dec 24, 2023

Thanks for the PR

@olekhshch olekhshch deleted the fix-panel branch December 25, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants