Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add redirect for the new frontend app in social network #404

Merged
merged 1 commit into from
Jan 25, 2024
Merged

add redirect for the new frontend app in social network #404

merged 1 commit into from
Jan 25, 2024

Conversation

hichri-louay
Copy link
Contributor

No description provided.

@hichri-louay hichri-louay merged commit b999d67 into develop Jan 25, 2024
3 checks passed
@hichri-louay hichri-louay deleted the redirect-social-networks-for-new-frontend branch January 25, 2024 17:45
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 25, 2024
View reviewed changes
routes/profile.routes.js
@@ -645,7 +645,7 @@
(req, res, next) => {
passport.authenticate('facebook_strategy_add_channel', {
failureRedirect:
process.env.BASED_URL+
req.query.state.includes('frontendApp=metamask') ? process.env.METAMASK_BASED_URL: process.env.BASED_URL+

Check failure

Code scanning / CodeQL

Type confusion through parameter tampering Critical

Potential type confusion as
this HTTP request parameter
Loading
may be either an array or a string.
routes/profile.routes.js
@@ -655,7 +655,7 @@
redirect = req.query.state.split('|')[1]
let message = req.authInfo.message
response.redirect(
process.env.BASED_URL+
req.query.state.includes('frontendApp=metamask') ? process.env.METAMASK_BASED_URL: process.env.BASED_URL+

Check failure

Code scanning / CodeQL

Type confusion through parameter tampering Critical

Potential type confusion as
this HTTP request parameter
Loading
may be either an array or a string.
routes/profile.routes.js
@@ -743,7 +743,7 @@
if (!req.query.error) next()
else
res.redirect(
process.env.BASED_URL+
req.query.state.includes('frontendApp=metamask') ? process.env.METAMASK_BASED_URL: process.env.BASED_URL+

Check failure

Code scanning / CodeQL

Type confusion through parameter tampering Critical

Potential type confusion as
this HTTP request parameter
Loading
may be either an array or a string.
routes/profile.routes.js
@@ -754,7 +754,7 @@
let redirect = req.query.state.split('|')[1]
let message = req.authInfo.message
res.redirect(
process.env.BASED_URL +
req.query.state.includes('frontendApp=metamask') ? process.env.METAMASK_BASED_URL: process.env.BASED_URL +

Check failure

Code scanning / CodeQL

Type confusion through parameter tampering Critical

Potential type confusion as
this HTTP request parameter
Loading
may be either an array or a string.
routes/profile.routes.js
@@ -804,7 +804,7 @@
(req, res, next) => {
passport.authenticate('tikTok_strategy_add_channel', {
failureRedirect:
process.env.BASED_URL +
req.query.state.includes('frontendApp=metamask') ? process.env.METAMASK_BASED_URL: process.env.BASED_URL +

Check failure

Code scanning / CodeQL

Type confusion through parameter tampering Critical

Potential type confusion as
this HTTP request parameter
Loading
may be either an array or a string.
routes/profile.routes.js
@@ -882,7 +882,7 @@
message = 'account_linked_with_success'
}
res.redirect(
process.env.BASED_URL + redirect + '?message=' + message
req.query.state.includes('frontendApp=metamask') ? process.env.METAMASK_BASED_URL: process.env.BASED_URL + redirect + '?message=' + message

Check failure

Code scanning / CodeQL

Type confusion through parameter tampering Critical

Potential type confusion as
this HTTP request parameter
Loading
may be either an array or a string.
routes/profile.routes.js
@@ -1181,7 +1181,7 @@
(req, res, next) => {
passport.authenticate('link_facebook_account', {
failureRedirect:
process.env.BASED_URL +
req.query.state.includes('frontendApp=metamask') ? process.env.METAMASK_BASED_URL: process.env.BASED_URL +

Check failure

Code scanning / CodeQL

Type confusion through parameter tampering Critical

Potential type confusion as
this HTTP request parameter
Loading
may be either an array or a string.
routes/profile.routes.js
@@ -1190,7 +1190,7 @@
let state = req.query.state.split('|')
let url = state[1]
response.redirect(
process.env.BASED_URL + url + '?message=' + req.authInfo.message
req.query.state.includes('frontendApp=metamask') ? process.env.METAMASK_BASED_URL: process.env.BASED_URL + url + '?message=' + req.authInfo.message

Check failure

Code scanning / CodeQL

Type confusion through parameter tampering Critical

Potential type confusion as
this HTTP request parameter
Loading
may be either an array or a string.
routes/profile.routes.js
@@ -1236,7 +1236,7 @@
(req, res, next) => {
passport.authenticate('link_google_account', {
failureRedirect:
process.env.BASED_URL +
req.query.state.includes('frontendApp=metamask') ? process.env.METAMASK_BASED_URL: process.env.BASED_URL +

Check failure

Code scanning / CodeQL

Type confusion through parameter tampering Critical

Potential type confusion as
this HTTP request parameter
Loading
may be either an array or a string.
routes/profile.routes.js
@@ -1245,7 +1245,7 @@
let state = req.query.state.split('|')
let url = state[1]
let message = req.authInfo.message
res.redirect(process.env.BASED_URL + url + '?message=' + message)
res.redirect(req.query.state.includes('frontendApp=metamask') ? process.env.METAMASK_BASED_URL: process.env.BASED_URL + url + '?message=' + message)

Check failure

Code scanning / CodeQL

Type confusion through parameter tampering Critical

Potential type confusion as
this HTTP request parameter
Loading
may be either an array or a string.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hichri-louay