Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for GCC alloc-size-larger-than warning #43

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Fix for GCC alloc-size-larger-than warning #43

merged 1 commit into from
Dec 8, 2020

Conversation

hv15
Copy link
Member

@hv15 hv15 commented Dec 7, 2020 •
edited
Loading

This PR resolves bug #42.

@hv15
Copy link
Member Author

hv15 commented Dec 7, 2020

Bugger, macos build fails because of clang: warning: no such sysroot directory: '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk' [-Wmissing-sysroot]. Github updated the MacOS 10.15 image and changed to a newer version of XCode where the evidently the SDK is located somewhere else. Either sac2c needs to be recompiled or we need to update the sac2crc file. Ahhh.

@hv15 hv15 mentioned this pull request Dec 7, 2020
Closed
7 tasks
@hv15 hv15 force-pushed the hans-arrayio-prt-fix branch from 98ab302 to c9e7b15 Compare December 7, 2020 21:31
@hv15 hv15 added the bug label Dec 7, 2020
ashinkarov
ashinkarov requested changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@ashinkarov ashinkarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just use RuntimeError when you terminate compilation, other than that looks good to me.

src/stdio/src/ArrayIO/PrintArray.c Outdated Show resolved Hide resolved
@hv15 hv15 force-pushed the hans-arrayio-prt-fix branch from c9e7b15 to 8619284 Compare December 8, 2020 09:52
@ashinkarov ashinkarov merged commit 9bb7419 into SacBase:master Dec 8, 2020
@hv15 hv15 mentioned this pull request Jan 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashinkarov ashinkarov ashinkarov approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hv15 @ashinkarov