Skip to content

Commit

Permalink
refactor: linter
Browse files Browse the repository at this point in the history
  • Loading branch information
SmiteDeluxe committed Jun 22, 2024
1 parent 72a4371 commit 6839ae9
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 7 deletions.
2 changes: 1 addition & 1 deletion packages/safe-ds-eda/src/apis/extensionApi.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { get } from 'svelte/store';
import type { HistoryEntry } from '../../types/state';
import { profilingLoading, table, history, tableLoading } from '../webviewState';
import { profilingLoading, table, history } from '../webviewState';
import type { ExecuteRunnerAllEntry } from '../../types/messaging';
import { filterHistoryOnlyInternal } from './historyApi';

Expand Down
3 changes: 0 additions & 3 deletions packages/safe-ds-eda/src/components/TableView.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,16 @@
possibleColumnFilters,
profilingOutdated,
history,
profilingLoading,
} from '../webviewState';
import CaretIcon from '../icons/Caret.svelte';
import ErrorIcon from '../icons/Error.svelte';
import FilterIcon from '../icons/Filter.svelte';
import type {
Column,
OneColumnTabTypes,
PossibleColumnFilter,
PossibleSorts,
Profiling,
ProfilingDetail,
ProfilingDetailStatistical,
TwoColumnTabTypes,
} from '../../types/state.js';
import ProfilingInfo from './profiling/ProfilingInfo.svelte';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@
};
const confirmValueRangeFilter = (totalMin: number, totalMax: number) => {
if (minValue == null || maxValue == null) return;
if (minValue === null || maxValue === null) return;
if (isInvalidRange(minValue, maxValue, totalMin, totalMax)) return;
if (minValue === totalMin && maxValue === totalMax) {
Expand Down Expand Up @@ -146,8 +146,8 @@
selectDone();
};
const isInvalidRange = (minValue: number, maxValue: number, totalMin: number, totalMax: number) => {
return minValue >= maxValue || minValue < totalMin || maxValue > totalMax;
const isInvalidRange = (minValueNow: number, maxValueNow: number, totalMin: number, totalMax: number) => {
return minValueNow >= maxValueNow || minValueNow < totalMin || maxValueNow > totalMax;
};
const removeFilters = () => {
Expand Down

0 comments on commit 6839ae9

Please sign in to comment.