Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: trigger EDA tool via code lenses #1010

Merged
merged 4 commits into from
Apr 8, 2024
Merged

feat: trigger EDA tool via code lenses #1010

merged 4 commits into from
Apr 8, 2024

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented Apr 8, 2024 •
edited
Loading

Summary of Changes

Show code lenses to trigger the EDA tool:

image

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2024 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ REPOSITORY git_diff yes no 0.05s
✅ TYPESCRIPT eslint 7 0 0 4.43s
✅ TYPESCRIPT prettier 7 0 0 1.07s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov Codecov
Copy link

codecov bot commented Apr 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (228733c) to head (907286e).
Report is 147 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##              main     #1010    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           98        99     +1     
  Lines        18778     18891   +113     
  Branches      3860      3879    +19     
==========================================
+ Hits         18778     18891   +113

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lars-reimann
Copy link
Member Author

lars-reimann commented Apr 8, 2024 •
edited
Loading

@SmiteDeluxe What do you think of this? Could this fully replace the runEdaFromContext command and entries in the context menu? Compared to those, it really is context-dependent and only shown for placeholders with type Table and if the runner is started.

@lars-reimann lars-reimann marked this pull request as ready for review April 8, 2024 17:28
@lars-reimann lars-reimann merged commit eb6e4b6 into main Apr 8, 2024
7 checks passed
@lars-reimann lars-reimann deleted the code-lens branch April 8, 2024 17:28
@lars-reimann lars-reimann mentioned this pull request Apr 8, 2024
Closed
lars-reimann pushed a commit that referenced this pull request Apr 10, 2024
@semantic-release-bot
chore(release): 0.11.0 [skip ci]
990fb04 
## [0.11.0](v0.10.0...v0.11.0) (2024-04-10)

### Features

* add `toFloat` methods for `Int` and `String` ([#1018](#1018)) ([55a2050](55a2050))
* fine-grained control over inlay hints for parameter names ([#1016](#1016)) ([2667caf](2667caf))
* messaging service ([#1004](#1004)) ([dcf4ecf](dcf4ecf))
* semantic highlighting of block lambda results ([#1011](#1011)) ([228733c](228733c))
* start runner in language server ([#1006](#1006)) ([ef4bb6f](ef4bb6f))
* stubs for int conversions ([#1008](#1008)) ([b635f5a](b635f5a))
* support relative paths ([#1019](#1019)) ([3d3f28d](3d3f28d))
* trigger EDA tool via code lenses ([#1010](#1010)) ([eb6e4b6](eb6e4b6))

### Bug Fixes

* consumption of source maps ([#1005](#1005)) ([ea3da87](ea3da87))
* disable global EDA panel cache ([#1014](#1014)) ([f888027](f888027)), closes [/github.com//issues/986#issuecomment-2042731653](https://github.com/Safe-DS//github.com/Safe-DS/DSL/issues/986/issues/issuecomment-2042731653)
* generation of dynamic member function calls with memoization + propagating of impurity information across chained calls ([#1015](#1015)) ([19015c3](19015c3)), closes [#1012](#1012) [#1013](#1013)
* only spawn one runner process and shut it down properly ([#1009](#1009)) ([2c72cee](2c72cee))
* show EDA tool for `TaggedTable` and `TimeSeries` ([#1017](#1017)) ([ffae98a](ffae98a))
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Apr 10, 2024
@SmiteDeluxe
Copy link
Contributor

@lars-reimann I know I am a bit late on this but I agree this is great! I was actually thinking about something similar to talk to you about, but guess that is now resolved! And I figure we might still want the context menu one in case of bugs/changes in vscode and it's sometimes breaking updates (in my experience) and as following the UX standard of allowing multiple paths to a goal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released Included in a release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lars-reimann @SmiteDeluxe