Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: __repr__ method to Schema, Row, Column, SupervisedDataset & Table; summary() to Column & Table #333

Merged
merged 16 commits into from
Jan 27, 2023
Merged

feat: __repr__ method to Schema, Row, Column, SupervisedDataset & Table; summary() to Column & Table #333

merged 16 commits into from
Jan 27, 2023

Conversation

GideonKoenig
Copy link
Contributor

Closes #319.

Summary of Changes

  • Added __str__(), __repr__() and _ipython_display_() methods to the classes Table, Column, Row, TableSchemaand SupervisedDataset.
  • Added the method summary() to the Table class
  • Changed the raised error in some of the ColumnStatistics methods from TypeError to NonNumericColumnError
  • Moved the methods idness() and stability() from the class Column to ColumnStatistics
    • Refactored the test accordingly

Testing Instructions

Create an instance of one of the mentioned classes and either call the print method on it or use the jupyter notebook interactive display method to visualize it in a prettier way.

@GideonKoenig GideonKoenig linked an issue Jan 20, 2023 that may be closed by this pull request
__repr__ method to Schema, Row, Column, SupervisedDataset & Table; summary() to Column & Table #319
Closed
@github-actions
Copy link

github-actions bot commented Jan 20, 2023 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 15 0 0.95s
✅ PYTHON black 15 0 0 1.18s
✅ PYTHON flake8 15 0 0.67s
✅ PYTHON isort 15 0 0 0.35s
✅ PYTHON mypy 15 0 3.02s
✅ PYTHON pylint 15 0 4.23s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented Jan 20, 2023 •
edited
Loading

Codecov Report

Merging #333 (c18bf32) into main (665686d) will increase coverage by 10.57%.
The diff coverage is 57.00%.

@@             Coverage Diff             @@
##             main     #333       +/-   ##
===========================================
+ Coverage   80.96%   91.53%   +10.57%     
===========================================
  Files         176       41      -135     
  Lines        6237     1040     -5197     
  Branches     1294        0     -1294     
===========================================
- Hits         5050      952     -4098     
+ Misses        813       88      -725     
+ Partials      374        0      -374
Impacted Files Coverage Δ
...untime/safe-ds/safe_ds/data/_supervised_dataset.py 61.53% <28.57%> (-38.47%) ⬇️
Runtime/safe-ds/safe_ds/data/_row.py 68.88% <42.10%> (-19.58%) ⬇️
Runtime/safe-ds/safe_ds/data/_column.py 89.51% <61.53%> (-2.31%) ⬇️
Runtime/safe-ds/safe_ds/data/_table_schema.py 93.93% <66.66%> (-2.84%) ⬇️
Runtime/safe-ds/safe_ds/data/_table.py 90.94% <68.88%> (-2.97%) ⬇️
...mann/safeds/serializer/SafeDSSyntacticSequencer.kt
...ann/safeds/validation/types/CallableTypeChecker.kt
.../larsreimann/safeds/stdlibAccess/StdlibPackages.kt
...eds/validation/typeChecking/ArgumentTypeChecker.kt
.../server/symbol/SafeDSDocumentSymbolNameProvider.kt
... and 132 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

WinPlay02
WinPlay02 reviewed Jan 20, 2023
View reviewed changes
Copy link
Contributor

@WinPlay02 WinPlay02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get_column_names is duplicated: Table, Row (already exists in TableSchema)

dorianheidorn
dorianheidorn previously approved these changes Jan 21, 2023
View reviewed changes
@WinPlay02 WinPlay02 merged commit 2c32eed into main Jan 27, 2023
@WinPlay02 WinPlay02 deleted the 319-__repr__-method-to-schema-row-column-table-info-to-column-table branch January 27, 2023 09:40
lars-reimann pushed a commit that referenced this pull request Apr 1, 2023
@dependabot
build(deps-dev): Bump esbuild from 0.17.11 to 0.17.14 in /DSL/com.lar…
4c8f2fc 
…sreimann.safeds.vscode (#442)

Bumps [esbuild](https://github.com/evanw/esbuild) from 0.17.11 to
0.17.14.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/evanw/esbuild/releases">esbuild's
releases</a>.</em></p>
<blockquote>
<h2>v0.17.14</h2>
<ul>
<li>
<p>Allow the TypeScript 5.0 <code>const</code> modifier in object type
declarations (<a
href="https://redirect.github.com/evanw/esbuild/issues/3021">#3021</a>)</p>
<p>The new TypeScript 5.0 <code>const</code> modifier was added to
esbuild in version 0.17.5, and works with classes, functions, and arrow
expressions. However, support for it wasn't added to object type
declarations (e.g. interfaces) due to an oversight. This release adds
support for these cases, so the following TypeScript 5.0 code can now be
built with esbuild:</p>
<pre lang="ts"><code>interface Foo { &lt;const T&gt;(): T }
type Bar = { new &lt;const T&gt;(): T }
</code></pre>
</li>
<li>
<p>Implement preliminary lowering for CSS nesting (<a
href="https://redirect.github.com/evanw/esbuild/issues/1945">#1945</a>)</p>
<p>Chrome has <a
href="https://developer.chrome.com/articles/css-nesting/">implemented
the new CSS nesting specification</a> in version 112, which is currently
in beta but will become stable very soon. So CSS nesting is now a part
of the web platform!</p>
<p>This release of esbuild can now transform nested CSS syntax into
non-nested CSS syntax for older browsers. The transformation relies on
the <code>:is()</code> pseudo-class in many cases, so the transformation
is only guaranteed to work when targeting browsers that support
<code>:is()</code> (e.g. Chrome 88+). You'll need to set esbuild's <a
href="https://esbuild.github.io/api/#target"><code>target</code></a> to
the browsers you intend to support to tell esbuild to do this
transformation. You will get a warning if you use CSS nesting syntax
with a <code>target</code> which includes older browsers that don't
support <code>:is()</code>.</p>
<p>The lowering transformation looks like this:</p>
<pre lang="css"><code>/* Original input */
a.btn {
  color: [#333](evanw/esbuild#333);
&amp;:hover { color: [#444](evanw/esbuild#444)
}
&amp;:active { color:
[#555](evanw/esbuild#555) }
}
<p>/* New output (with --target=chrome88) */
a.btn {
color: <a
href="https://redirect.github.com/evanw/esbuild/issues/333">#333</a>;
}
a.btn:hover {
color: <a
href="https://redirect.github.com/evanw/esbuild/issues/444">#444</a>;
}
a.btn:active {
color: <a
href="https://redirect.github.com/evanw/esbuild/issues/555">#555</a>;
}
</code></pre></p>
<p>More complex cases may generate the <code>:is()</code>
pseudo-class:</p>
<pre lang="css"><code>/* Original input */
div, p {
  .warning, .error {
    padding: 20px;
  }
}
<p>/* New output (with --target=chrome88) */
:is(div, p) :is(.warning, .error) {
</code></pre></p>
</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/evanw/esbuild/blob/main/CHANGELOG.md">esbuild's
changelog</a>.</em></p>
<blockquote>
<h2>0.17.14</h2>
<ul>
<li>
<p>Allow the TypeScript 5.0 <code>const</code> modifier in object type
declarations (<a
href="https://redirect.github.com/evanw/esbuild/issues/3021">#3021</a>)</p>
<p>The new TypeScript 5.0 <code>const</code> modifier was added to
esbuild in version 0.17.5, and works with classes, functions, and arrow
expressions. However, support for it wasn't added to object type
declarations (e.g. interfaces) due to an oversight. This release adds
support for these cases, so the following TypeScript 5.0 code can now be
built with esbuild:</p>
<pre lang="ts"><code>interface Foo { &lt;const T&gt;(): T }
type Bar = { new &lt;const T&gt;(): T }
</code></pre>
</li>
<li>
<p>Implement preliminary lowering for CSS nesting (<a
href="https://redirect.github.com/evanw/esbuild/issues/1945">#1945</a>)</p>
<p>Chrome has <a
href="https://developer.chrome.com/articles/css-nesting/">implemented
the new CSS nesting specification</a> in version 112, which is currently
in beta but will become stable very soon. So CSS nesting is now a part
of the web platform!</p>
<p>This release of esbuild can now transform nested CSS syntax into
non-nested CSS syntax for older browsers. The transformation relies on
the <code>:is()</code> pseudo-class in many cases, so the transformation
is only guaranteed to work when targeting browsers that support
<code>:is()</code> (e.g. Chrome 88+). You'll need to set esbuild's <a
href="https://esbuild.github.io/api/#target"><code>target</code></a> to
the browsers you intend to support to tell esbuild to do this
transformation. You will get a warning if you use CSS nesting syntax
with a <code>target</code> which includes older browsers that don't
support <code>:is()</code>.</p>
<p>The lowering transformation looks like this:</p>
<pre lang="css"><code>/* Original input */
a.btn {
  color: [#333](evanw/esbuild#333);
&amp;:hover { color: [#444](evanw/esbuild#444)
}
&amp;:active { color:
[#555](evanw/esbuild#555) }
}
<p>/* New output (with --target=chrome88) */
a.btn {
color: <a
href="https://redirect.github.com/evanw/esbuild/issues/333">#333</a>;
}
a.btn:hover {
color: <a
href="https://redirect.github.com/evanw/esbuild/issues/444">#444</a>;
}
a.btn:active {
color: <a
href="https://redirect.github.com/evanw/esbuild/issues/555">#555</a>;
}
</code></pre></p>
<p>More complex cases may generate the <code>:is()</code>
pseudo-class:</p>
<pre lang="css"><code>/* Original input */
div, p {
  .warning, .error {
    padding: 20px;
  }
}
<p>/* New output (with --target=chrome88) */
</code></pre></p>
</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/evanw/esbuild/commit/b2b897870564a6b8e8bc802a140c55bf602de31b"><code>b2b8978</code></a>
publish 0.17.14 to npm</li>
<li><a
href="https://github.com/evanw/esbuild/commit/079eca4992344201185864c9282221c917c9a3d5"><code>079eca4</code></a>
fix <a
href="https://redirect.github.com/evanw/esbuild/issues/3021">#3021</a>:
add support for <code>const</code> in object types</li>
<li><a
href="https://github.com/evanw/esbuild/commit/72c837935d74ab1f421c0d96e9d1ce1052438737"><code>72c8379</code></a>
fix <a
href="https://redirect.github.com/evanw/esbuild/issues/1945">#1945</a>:
initial lowering code for css nesting</li>
<li><a
href="https://github.com/evanw/esbuild/commit/96e09b40f73b29aaf4f419d45f603ee1353be800"><code>96e09b4</code></a>
cannot inline no-op nesting with pseudo-elements</li>
<li><a
href="https://github.com/evanw/esbuild/commit/cd62fa131daecaf8eb4b4bb032331158b2b2d8db"><code>cd62fa1</code></a>
minify: remove unnecessary <code>&amp;</code> selectors</li>
<li><a
href="https://github.com/evanw/esbuild/commit/0546cf7a8cb1d89409e4634bdb3b5d6c65e0a6c5"><code>0546cf7</code></a>
css combinator can be a single byte</li>
<li><a
href="https://github.com/evanw/esbuild/commit/39c39620829dad7f871e32090d4273ed4fdc0ae2"><code>39c3962</code></a>
minify: removes duplicates from CSS selector lists</li>
<li><a
href="https://github.com/evanw/esbuild/commit/8362c373289da762f5636691fc070f630678607c"><code>8362c37</code></a>
Chrome 112+ can now use CSS nesting</li>
<li><a
href="https://github.com/evanw/esbuild/commit/366b632dec741af6f199ef2931b2f0936a9ff822"><code>366b632</code></a>
<a
href="https://redirect.github.com/evanw/esbuild/issues/2940">#2940</a>:
switch to <code>node-compat-table</code> for node data</li>
<li><a
href="https://github.com/evanw/esbuild/commit/daf372df0bea9109b89ddf3bf1703eb5daef4d52"><code>daf372d</code></a>
run <code>make compat-table</code> again</li>
<li>Additional commits viewable in <a
href="https://github.com/evanw/esbuild/compare/v0.17.11...v0.17.14">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=esbuild&package-manager=npm_and_yarn&previous-version=0.17.11&new-version=0.17.14)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marsmaennchen221 Marsmaennchen221 Marsmaennchen221 approved these changes

@WinPlay02 WinPlay02 WinPlay02 approved these changes

@dorianheidorn dorianheidorn dorianheidorn left review comments

@lars-reimann lars-reimann Awaiting requested review from lars-reimann lars-reimann is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

__repr__ method to Schema, Row, Column, SupervisedDataset & Table; summary() to Column & Table
5 participants
@GideonKoenig @WinPlay02 @dorianheidorn @Marsmaennchen221 @SmiteDeluxe