Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve tests for formatter and grammar #544

Merged
merged 5 commits into from
Aug 8, 2023

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented Aug 8, 2023

Summary of Changes

  • Add tests for the idempotence of formatter
  • Clear documents between tests to avoid colliding URIs
  • Move test creation code to a separate file, so it can be tested
  • Bump dependencies
  • Various bug fixes

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #544 (b003b6b) into main (9662469) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #544   +/-   ##
=======================================
  Coverage   99.56%   99.56%           
=======================================
  Files           7        7           
  Lines        1149     1149           
  Branches      238      238           
=======================================
  Hits         1144     1144           
  Misses          5        5           
Components Coverage Δ
dsl 99.55% <100.00%> (ø)
runner 100.00% <ø> (ø)
Files Changed Coverage Δ
...rc/language-server/formatting/safe-ds-formatter.ts 99.78% <100.00%> (ø)

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ JSON eslint-plugin-jsonc 2 0 0 1.23s
✅ JSON jsonlint 2 0 0.17s
✅ JSON npm-package-json-lint yes no 0.51s
✅ JSON prettier 2 0 0 0.7s
✅ JSON v8r 2 0 3.75s
✅ REPOSITORY git_diff yes no 0.04s
✅ TYPESCRIPT eslint 12 0 0 5.54s
✅ TYPESCRIPT prettier 12 0 0 1.81s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@lars-reimann lars-reimann merged commit c3c2aef into main Aug 8, 2023
@lars-reimann lars-reimann deleted the better-formatter-grammar-tests branch August 8, 2023 14:06
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants