Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix failing tests due to colliding file names #569

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented Sep 20, 2023

Summary of Changes

Clear files loaded into workspace by tests in additional places to prevent colliding file names. This does not fully solve the issue yet, but together with the upcoming update to Langium it should get rid of it completely.

@github-actions
Copy link

github-actions bot commented Sep 20, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ REPOSITORY git_diff yes no 0.04s
✅ TYPESCRIPT eslint 7 0 0 4.84s
✅ TYPESCRIPT prettier 7 0 0 1.0s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@lars-reimann lars-reimann force-pushed the fix-file-name-exists-already branch 3 times, most recently from f0988aa to 5436f55 Compare September 20, 2023 20:47
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #569 (f0c2727) into main (48b5f53) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #569   +/-   ##
=======================================
  Coverage   99.72%   99.72%           
=======================================
  Files          14       14           
  Lines        1809     1809           
  Branches      373      373           
=======================================
  Hits         1804     1804           
  Misses          5        5           
Files Changed Coverage Δ
src/language/builtins/safe-ds-workspace-manager.ts 100.00% <ø> (ø)
src/language/safe-ds-module.ts 100.00% <100.00%> (ø)

@lars-reimann lars-reimann force-pushed the fix-file-name-exists-already branch from 5436f55 to 7c4655b Compare September 20, 2023 21:03
@lars-reimann lars-reimann force-pushed the fix-file-name-exists-already branch from 7c4655b to 84f3d91 Compare September 20, 2023 21:06
@lars-reimann lars-reimann merged commit f6ffa4d into main Sep 20, 2023
@lars-reimann lars-reimann deleted the fix-file-name-exists-already branch September 20, 2023 21:10
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants