Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove redundant formatter tests #747

Merged
merged 5 commits into from
Nov 9, 2023

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented Nov 9, 2023

Closes #745

Summary of Changes

Formatting tests were difficult to maintain since several tests were testing the same rules in different contexts, including the formatting for

  • lists of constraints,
  • lists of parameters,
  • lists of results,
  • lists of type parameter,
  • classes (global vs. nested),
  • enum (global vs. nested),
  • functions (global vs. method).

This made changes and additions cumbersome. This PR extracts the tests for these rules and removes the redundant ones.

@lars-reimann lars-reimann linked an issue Nov 9, 2023 that may be closed by this pull request
@lars-reimann lars-reimann changed the title test: remove redundant grammar tests test: remove redundant formatter tests Nov 9, 2023
Copy link

github-actions bot commented Nov 9, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ REPOSITORY git_diff yes no 0.07s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #747 (738b7c2) into main (fe1a115) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #747   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           80        80           
  Lines        11211     11211           
  Branches      2341      2341           
=========================================
  Hits         11211     11211           

@lars-reimann lars-reimann marked this pull request as ready for review November 9, 2023 22:14
@lars-reimann lars-reimann merged commit 6510555 into main Nov 9, 2023
9 checks passed
@lars-reimann lars-reimann deleted the 745-streamline-formatter-tests branch November 9, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Streamline formatter tests
1 participant