feat: simplify substitutions passed to computeType
#873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #873 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 91 91
Lines 15923 15937 +14
Branches 3247 3249 +2
=========================================
+ Hits 15923 15937 +14 ☔ View full report in Codecov by Sentry. |
lars-reimann
pushed a commit
that referenced
this pull request
Feb 12, 2024
## [0.7.0](v0.6.0...v0.7.0) (2024-02-12) ### Features * apply type parameter substitutions of receiver type for member accesses ([#859](#859)) ([5780ed7](5780ed7)), closes [#23](#23) * check position of usages of variant type parameters ([#852](#852)) ([a2672d7](a2672d7)), closes [#743](#743) * check whether lower and upper bounds of a type parameter are compatible ([#885](#885)) ([2fc7fe6](2fc7fe6)), closes [#875](#875) * check whether type parameter bounds are acyclic ([#886](#886)) ([bcf1a4b](bcf1a4b)), closes [#874](#874) * check whether type parameter bounds are named types ([#878](#878)) ([d8b4168](d8b4168)), closes [#876](#876) * error if type parameter has multiple lower/upper bounds ([#870](#870)) ([6035b76](6035b76)), closes [#867](#867) * error if type parameter of class is used in static context ([#830](#830)) ([d5cf420](d5cf420)), closes [#809](#809) * error if type parameters of functions are variant ([#869](#869)) ([9bf5fec](9bf5fec)) * handle type parameter types in type checker ([#884](#884)) ([6b6f738](6b6f738)), closes [#877](#877) * handle type parameters (part 1) ([#856](#856)) ([8a35558](8a35558)), closes [#23](#23) * improve type simplification ([#871](#871)) ([0daafb9](0daafb9)) * Memoization ([#827](#827)) ([d0a6c71](d0a6c71)) * null-safe call & indexed access ([#872](#872)) ([f1420a2](f1420a2)), closes [#857](#857) [#858](#858) * optional type parameters ([#829](#829)) ([0e9f67a](0e9f67a)), closes [#739](#739) * optionally generate code without runner integration ([#836](#836)) ([0ed9d6e](0ed9d6e)), closes [#831](#831) * pre-load all relevant workspace files before executing pipeline ([#822](#822)) ([67ab766](67ab766)) * simplify computed types ([#866](#866)) ([bde3274](bde3274)) * simplify substitutions passed to `computeType` ([#873](#873)) ([aa444d4](aa444d4)) * substitute type parameters when checking assignability of overriding members ([#865](#865)) ([a1f24e0](a1f24e0)), closes [#862](#862) * substitute type parameters when computing type of inherited members ([#864](#864)) ([33de1e8](33de1e8)), closes [#863](#863) * support placeholder queries that only request a subset of data ([#826](#826)) ([1e39300](1e39300)) * type casts ([#838](#838)) ([66c3666](66c3666)), closes [#835](#835) ### Bug Fixes * allow usage of covariant type parameters in own constructor ([#854](#854)) ([4ebae94](4ebae94)) * check for duplicate bounds if type parameters occur as right operand ([#882](#882)) ([8776ce0](8776ce0)), closes [#881](#881) * generation of static class functions ([#832](#832)) ([57eac45](57eac45))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
computeTypetakes type parameter substitutions as an argument, which get applied before the result is returned. Previously, the substitutions were used as they were given. Now they get simplified before they are applied.