-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add that the number_of_rows
will be set to 0 when removing the last column
#384
Conversation
…e last column Co-authored-by: patrikguempel <128832338+patrikguempel@users.noreply.github.com>
Co-authored-by: patrikguempel <128832338+patrikguempel@users.noreply.github.com>
Co-authored-by: patrikguempel <128832338+patrikguempel@users.noreply.github.com>
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Codecov Report
@@ Coverage Diff @@
## main #384 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 47 47
Lines 2353 2353
=========================================
Hits 2353 2353
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…-when-removing-the-last-column-so-the-table-gets-empty
…-when-removing-the-last-column-so-the-table-gets-empty
🎉 This PR is included in version 0.14.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Closes #276
Summary of Changes
When removing the only column in a 1-column-table, the number_of_rows property is set to 0. This behaviour should be documented in the Table class docstring as well as in the following methods: Table.keep_only_columns, Table.remove_columns, Table.remove_columns_with_missing_values and Table.remove_columns_with_non_numerical_values.