Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve error handling of column.stability when given a column that contains only None #388

Merged
merged 4 commits into from
Jun 23, 2023
Merged

feat: improve error handling of column.stability when given a column that contains only None #388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
35e9df8
feat: improve error handling of `column.stability` when given a colum…
alex-senger Jun 23, 2023
5f21368
Merge branch 'main' into 319-better-error-for-columnstability-if-the-…
alex-senger Jun 23, 2023
cf5d6f0
Apply suggestions from code review
alex-senger Jun 23, 2023
28f85a0
Merge branch 'main' of https://github.com/Safe-DS/Stdlib into 319-bet…
alex-senger Jun 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/safeds/data/tabular/containers/_column.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,7 @@ def stability(self) -> float:
\frac{\text{number of occurrences of most common non-null value}}{\text{number of non-null values}}
$$

The stability cannot be calculated for a column with only null values.
The stability is not definded for a column with only null values.

Returns
-------
Expand All @@ -520,7 +520,7 @@ def stability(self) -> float:
raise ColumnSizeError("> 0", "0")

if self.all(lambda x: x is None):
raise ValueError("Stability cannot be calculated for a column with only null values.")
raise ValueError("Stability is not definded for a column with only null values.")

return self._data.value_counts()[self.mode()[0]] / self._data.count()

Expand Down
2 changes: 1 addition & 1 deletion tests/safeds/data/tabular/containers/_column/test_stability.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,5 @@ def test_should_raise_column_size_error_if_column_is_empty() -> None:

def test_should_raise_value_error_if_column_contains_only_none() -> None:
column: Column[Any] = Column("A", [None, None])
with pytest.raises(ValueError, match="Stability cannot be calculated for a column with only null values."):
with pytest.raises(ValueError, match="Stability is not definded for a column with only null values."):
column.stability()