-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: use numpy<2.0.0 #899
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #899 +/- ##
=======================================
Coverage 97.73% 97.73%
=======================================
Files 121 121
Lines 6499 6499
=======================================
Hits 6352 6352
Misses 147 147 ☔ View full report in Codecov by Sentry. |
Why do we need to pin the version of transitive dependencies? Doesn't torchvision declare itself that it needs major version 1 for numpy? |
torchvision does not specify any restrictions on the numpy version and as of pytorch version 2.3.0 pytorch does support numpy v2.0. While torchvision claims to be 98% compatible to Numpy v2.0, a few important methods like |
😠 |
🎉 This PR is included in version 0.27.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Summary of Changes
Add clause to
pyproject.toml
to use a numpy version below 2.0 as torchvision does not yet support numpy 2.0 (See #898)