fix(simple-select): change the test story format from mdx to js - FE-4332 #4411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 887fc58:
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
mmaciorowski-sage
force-pushed
the
FE-4332-simple-select-mdx-test-story-issue
branch
from
9ab8737 to
ab91fdd
Compare
mmaciorowski-sage
force-pushed
the
FE-4332-simple-select-mdx-test-story-issue
branch
from
ab91fdd to
c57322a
Compare
mmaciorowski-sage
force-pushed
the
FE-4332-simple-select-mdx-test-story-issue
branch
from
c57322a to
0b681e3
Compare
Good point, changed, thanks |
DipperTheDan
approved these changes
Sep 21, 2021
edleeks87
approved these changes
Sep 22, 2021
edleeks87
approved these changes
Sep 22, 2021
ZhuoyuJin
approved these changes
Sep 24, 2021
mmaciorowski-sage
deleted the
FE-4332-simple-select-mdx-test-story-issue
branch
|
🎉 This PR is included in version 90.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
Change format from mdx to js until storybookjs/storybook#11542 is resolved.
Current behaviour
Simple select story doesn't work correctly.
Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions
/?path=/docs/design-system-select-test--default-story