Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CI to use matrix of 2.5 to 3.2 #106

Merged
merged 8 commits into from
Jan 10, 2024
Merged

Change CI to use matrix of 2.5 to 3.2 #106

merged 8 commits into from
Jan 10, 2024

Commits on Dec 14, 2023

  1. Refactor aws_calculate_visibility_timeout

    * Extract check for max retry delay to its own method
    * Use milliseconds throughout the class and only convert to seconds when
      returning the final visibility timeout
    * Use guard clauses in the check_... methods
    * Ensure adhering to limits inside the timeout method
    florianpilz committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    f901452 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. Add option for jitter in retry delays

    Jitter, or randomness in signals, is a common technique for avoiding
    calls that fail at the same time to retry at the same time. Therefore
    jitter can help avoid the thundering herd problem, where many instances
    of the same application all retry at the same time, causing a spike in
    load on the system. For example, if a service was down for some reason
    and comes back up, all queued events will hit at once and could cause
    the service to fail for most events. However, without jitter, the events
    will all retry at the same time, causing the same problem. Adding some
    jitter (or randomness) to the retry delays result in the events retrying
    at different times.
    
    In our implementation, the configuration says how much jitter is used
    based on the retry delay. For example, if `retry_jitter_ratio` is set to
    0, no jitter will be applied and all events will retry after the usual
    retry delay. If it is set to 100, the retry delay will be a random
    number between 0 and the retry delay without jitter. If it is set to 20,
    the retry delay will be a random number between 80 and 100% of the retry
    delay without jitter.
    florianpilz committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    d3b80f7 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. Configuration menu
    Copy the full SHA
    55a95a2 View commit details
    Browse the repository at this point in the history
  2. Bump codeclimate action

    guille-sage committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    9e986fd View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2023

  1. Configuration menu
    Copy the full SHA
    efbb1f6 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2023

  1. Adjust script and source path

    As we are now setting `src` as the default folder, we can just use the
    container loop from the mounted `src` volume. Also adjust paths in
    README and test script to work from root, rather inside the `script`
    folder.
    florianpilz committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    9f5c0c4 View commit details
    Browse the repository at this point in the history
  2. Add healthchecks to wait for services being ready

    In the upgraded environment with Ruby 3 booting up localstack takes too
    long, so some tests relying on it fail before it becomes available.
    Solution is just to add healthchecks and to wait for them to be healthy
    before starting tests. Also add this for Rspec test action on GitHub to
    avoid flaky test runs.
    florianpilz committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    0349c82 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d40ef02 View commit details
    Browse the repository at this point in the history