Fix concurrent access on task returnError

SagerNet · Sep 30, 2023 · e727641 · e727641
1 parent 63b82af
commit e727641
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/common/task/task.go b/common/task/task.go
@@ -87,16 +87,18 @@ func (g *Group) RunContextList(contextList []context.Context) error {
 	}
 
 	selectedContext, upstreamErr := common.SelectContext(append([]context.Context{taskCancelContext}, contextList...))
-	if selectedContext != 0 {
-		returnError = E.Append(returnError, upstreamErr, func(err error) error {
-			return E.Cause(err, "upstream")
-		})
-	}
 
 	if g.cleanup != nil {
 		g.cleanup()
 	}
 
 	<-taskContext.Done()
+
+	if selectedContext != 0 {
+		returnError = E.Append(returnError, upstreamErr, func(err error) error {
+			return E.Cause(err, "upstream")
+		})
+	}
+
 	return returnError
 }